Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull_request_template.md #452

Merged
merged 2 commits into from
Jan 20, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 14 additions & 22 deletions docs/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,37 +1,29 @@
## Description

Please include a summary of the change and which issue/s is/are fixed.
Include a summary of the change/s.
Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #
Issue/s resolved: #

Changes proposed:
## Changes proposed:
-
-
-
-

## Type of change

Select relevant options.
Remove irrelevant options:
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- Documentation update

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation update
## Due Diligence

Are all split configurations tested and accounted for?
- [ ] yes
- [ ] no
- [ ] All split configurations tested
- [ ] Multiple dtypes tested in relavent functions
- [ ] Documentation updated (if needed)

Does this change require a documentation update outside of the changes proposed?
- [ ] yes
- [ ] no

Does this change modify the behaviour of other functions?
- [ ] yes
- [ ] no

Are there code practices which require justification?
- [ ] yes
- [ ] no
#### Does this change modify the behaviour of other functions? If so, which?
yes / no