You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
When using the concatenate function, the comm of the result is eventually a different one than the comm of the input arrays. The comm will be changed when it's not ht.MPI_WORLD but another custom one. The concatenate function does not specify a comm internally and thus the ht.MPI_WORLD comm will be used for the result.
To Reproduce
Steps to reproduce the behavior:
a = ht.arange(23, split=0, comm=MPICommunication())
b = ht.zeros(2, comm=a.comm)
print('a', a.comm)
print('b', b.comm)
c = ht.concatenate((b, a))
print('c', c.comm)
Steps to reproduce the behavior:
Which module/class/function is affected? concatenate in manipualtions
What are the circumstances under which the bug appears?
setting a custom communicator
What is the exact error-message/errorous behavious?
No error message, just unexpected behaviour.
Expected behavior
A comm of the input arrays should be used
Additional comments
I am not quite sure what the expected behaviour here would be.
The text was updated successfully, but these errors were encountered:
we leave it as it is. in this case the returned DNDarray has its own communicator and it is assumed that we are working on the whole world.
we use the communicator from one of the inputs
I am partial to the first. i think that a new array should have its own communicator. however I have just noticed a different bug in cat: the inputs are unbalanced in the process of the code but they are not re-balanced at the end of the function
Description
When using the
concatenate
function, the comm of the result is eventually a different one than the comm of the input arrays. The comm will be changed when it's notht.MPI_WORLD
but another custom one. Theconcatenate
function does not specify a comm internally and thus theht.MPI_WORLD
comm will be used for the result.To Reproduce
Steps to reproduce the behavior:
Steps to reproduce the behavior:
concatenate
inmanipualtions
setting a custom communicator
No error message, just unexpected behaviour.
Expected behavior
A comm of the input arrays should be used
Additional comments
I am not quite sure what the expected behaviour here would be.
The text was updated successfully, but these errors were encountered: