Different dtypes testing #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coquelin77
requested changes
Dec 4, 2019
| @@ -209,9 +293,50 @@ def assert_func_equal( | |||
| else: | |||
| self.assertTrue(np.array_equal(ht_res._DNDarray__array.numpy(), np_res)) | |||
|
|
|||
| def _create_random_array(self, shape): | |||
| def _create_random_array(self, shape, dtype=np.float64, low=-10000, high=10000): | |||
There was a problem hiding this comment.
can you note that this creates a numpy array? others might misjudge it by its name, maybe just change array to np_array? just a thought
There was a problem hiding this comment.
I changed the name to __create_random_np_array
|
also can you trigger a new coverage run? |
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 98% 98.02% +0.01%
==========================================
Files 55 55
Lines 11041 11066 +25
==========================================
+ Hits 10821 10847 +26
+ Misses 220 219 -1
Continue to review full report at Codecov.
|
added 2 commits
December 4, 2019 09:49
|
I removed the communicator tests in favour of #422. Once this discussion comes to a conclusion, the comm test might be added again. |
1 task
coquelin77
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After I used the TestSuite for the first time in production I found some useful functionalities to extend the module with.
As @coquelin77 requested, the TestSuite is now testing on multiple dtypes which can also be defined by the user.
Internally it used
np.random.randnfor float values andnp.random.randintfor integer values.The latter one also accepts arguments for upper and lower bound of the random values.
Added to that, debugging messages were made more precise about when a exception is risen.
Type of change
Select relevant options.
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
Are all split configurations tested and accounted for?
[x] yes [ ] no
Does this change require a documentation update outside of the changes proposed?
[ ] yes [x] no
Does this change modify the behaviour of other functions?
[ ] yes [x] no
Are there code practices which require justification?
[ ] yes [x] no