diag() and diagonal() feature #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
+ Coverage 98.02% 98.05% +0.03%
==========================================
Files 55 55
Lines 11066 11285 +219
==========================================
+ Hits 10847 11066 +219
Misses 219 219
Continue to review full report at Codecov.
|
|
I also made some small changes in the |
coquelin77
requested changes
Nov 26, 2019
added 5 commits
November 28, 2019 10:57
…han upper bound (numpy returns empty array) and cleaned up code
|
tests failing, bump |
added 4 commits
December 4, 2019 10:48
# Conflicts: # heat/core/manipulations.py # heat/core/tests/test_manipulations.py
TheSlimvReal
commented
Dec 6, 2019
There was a problem hiding this comment.
I merge the branch #420 into this to get the correctly working unit test.
Please merge that branch before this one.
coquelin77
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR targets issue #242.
The returned array of
diag()in case of creating a diagonal array, will be split the same as the input array (split=Noneorsplit=0).Type of change
Select relevant options.
Are all split configurations tested and accounted for?
[x] yes - [ ] no
Does this change require a documentation update outside of the changes proposed?
[ ] yes [x] no
Does this change modify the behaviour of other functions?
[ ] yes [x] no
Are there code practices which require justification?
[ ] yes [x] no