Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sanitation module #468

Closed
ClaudiaComito opened this issue Jan 28, 2020 · 2 comments
Closed

Implement sanitation module #468

ClaudiaComito opened this issue Jan 28, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ClaudiaComito
Copy link
Contributor

Feature functionality
Collect sanitation checks in a dedicated module. This would include the omnipresent

if not isinstance(x, dndarray.DNDarray):
        raise TypeError("expected x to be a ht.DNDarray, but was {}".format(type(x)))

and variations thereof, but also more specific checks needed in high-level algorithms. See sklearn's validation module:

https://github.com/scikit-learn/scikit-learn/blob/b194674c4/sklearn/utils/validation.py

@ClaudiaComito ClaudiaComito added enhancement New feature or request organizational Issues concerning organizational, structural or regulatory affairs labels Jan 28, 2020
@ClaudiaComito ClaudiaComito removed the organizational Issues concerning organizational, structural or regulatory affairs label Jan 28, 2020
@Cdebus
Copy link
Contributor

Cdebus commented Feb 15, 2020

This should probably also handle communication and device sanitation. That is something that pops up frequently, but is a bit tedious to check for in each function individually. So if you make a general sanitation function, could you include this?

@Cdebus Cdebus mentioned this issue Feb 15, 2020
4 tasks
@ClaudiaComito ClaudiaComito self-assigned this Jun 23, 2020
@ClaudiaComito ClaudiaComito modified the milestones: v0.5.0, 2-week sprint Jun 30, 2020
@ClaudiaComito ClaudiaComito mentioned this issue Jul 2, 2020
4 tasks
@ClaudiaComito ClaudiaComito removed this from the 2-week sprint milestone Jul 2, 2020
This was referenced Sep 11, 2020
@ClaudiaComito
Copy link
Contributor Author

Closed by #662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants