-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/178 tile #673
Features/178 tile #673
Conversation
…at into features/178-tile
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
========================================
Coverage 95.40% 95.40%
========================================
Files 64 64
Lines 9246 9380 +134
========================================
+ Hits 8821 8949 +128
- Misses 425 431 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@mtar belated thanks for commenting, yes you are tiling a 1-D array with 2-dimensional repetitions, in this case |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code itself looks fine, but i found a bug in the alltoallv logic:
x = ht.arange(3*3).reshape((3, 3)).resplit(1)
print(x)
>>> DNDarray([[0, 1, 2],
[3, 4, 5],
[6, 7, 8]], dtype=ht.int32, device=cpu:0, split=1)
y = ht.tile(x, (2, 3))
print(y)
>>> DNDarray([[ 0, 4, 2, 0, 4, 2, 0, 4, 2],
[ 1, 1, 0, 1, 22065, 32628, 1, 32628, 0],
[ 3, 0, 0, 3, 0, 724118576, 3, 0, 0],
[ 0, 4, 2, 0, 4, 2, 0, 4, 2],
[ 1, 1, 0, 1, 22065, 32628, 1, 32628, 0],
[ 3, 0, 0, 3, 0, 724118576, 3, 0, 0]], dtype=ht.int32, device=cpu:0, split=1)
Good catch! Fixed |
then this is ready as far as i can tell |
Description
Implementation of heat version of np.tile():
https://numpy.org/doc/stable/reference/generated/numpy.tile.html
Alltoallv
- also, introducing sanitation module Implement sanitation module #468 (with only a few basic functions), the idea is to expand it on the fly as neededIssue/s resolved: #178
Changes proposed:
manipulations.tile()
, after https://numpy.org/doc/stable/reference/generated/numpy.tile.htmlType of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no