Add solver for distributed triangular systems #1236

mrfh92 · 2023-10-10T08:58:27Z

This PR is intended to add a triangular solver (see, e.g., torch.linalg.solve_triangular) to Heat; see #1096.

Due Diligence

General:
- base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
- title of the PR is suitable to appear in the Release Notes
Implementation:
- unit tests: all split configurations tested
- unit tests: multiple dtypes tested
- documentation updated where needed

…ll cases covered, may be inefficient, no tests so far!)

ghost · 2023-10-10T09:00:08Z

👇 Click on the image for a new way to code review

Legend

mrfh92 · 2023-10-10T09:03:44Z

Things to be addressed:

all combinations of splits for A and b; b either vector or matrix
performance (scaling)
unit tests to be added

github-actions · 2023-10-10T09:03:46Z

Thank you for the PR!

codecov · 2023-10-10T09:48:18Z

Codecov Report

Attention: Patch coverage is 90.10989% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 92.04%. Comparing base (6e9e9ec) to head (6589754).
Report is 1 commits behind head on main.

Files	Patch %	Lines
heat/core/linalg/solver.py	90.10%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
- Coverage   92.06%   92.04%   -0.02%     
==========================================
  Files          80       80              
  Lines       11941    12031      +90     
==========================================
+ Hits        10993    11074      +81     
- Misses        948      957       +9

Flag	Coverage Δ
unit	`92.04% <90.10%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-10-10T11:02:09Z

Thank you for the PR!

github-actions · 2023-10-12T07:50:07Z

Thank you for the PR!

github-actions · 2023-12-18T02:08:48Z

This pull request is stale because it has been open for 60 days with no activity.

…r_systems

github-actions · 2023-12-18T09:51:45Z

Thank you for the PR!

mrfh92 · 2023-12-18T11:24:41Z

Things to be done:

which cases have been covered so far? (which combinations of A.split $\in$ {0, 1,, None}, b.split $\in$ {0, 1,, None})
tests need to be added for the cases covered so far
does extension to the cases not covered so far make sense (from the algorithmic point of view)?

…r_systems

github-actions · 2024-01-03T14:49:40Z

Thank you for the PR!

mrfh92 · 2024-01-10T14:01:27Z

With a view on #1104 #1320 it might also be usefull to include the case of batched inputs (however, for the moment it should suffice to cover the simple case split=batch-dimension)

github-actions · 2024-01-16T17:28:43Z

Thank you for the PR!

github-actions · 2024-01-17T13:41:59Z

Thank you for the PR!

github-actions · 2024-01-17T15:47:47Z

Thank you for the PR!

…r_systems

github-actions · 2024-01-22T12:20:56Z

Thank you for the PR!

mrfh92 · 2024-01-22T14:54:54Z

There seems to be an error that is not due to the (meanwhile) resolved QR errors etc.

github-actions · 2024-04-03T11:09:54Z

Thank you for the PR!

…r_systems

github-actions · 2024-04-11T08:27:16Z

Thank you for the PR!

ClaudiaComito

Thanks a lot for the changes @mrfh92 @FOsterfeld , looks great, I only have a few more editing suggestions.

heat/core/linalg/solver.py

Co-authored-by: Claudia Comito <39374113+ClaudiaComito@users.noreply.github.com>

github-actions · 2024-04-11T09:05:37Z

Thank you for the PR!

github-actions · 2024-04-11T09:07:29Z

Thank you for the PR!

@ClaudiaComito

incorporated @ClaudiaComito's suggestions for docstring

mrfh92 · 2024-04-11T09:19:02Z

@ClaudiaComito I have taken your review into account now.

…r_systems

github-actions · 2024-04-11T09:23:15Z

Thank you for the PR!

github-actions · 2024-04-11T09:28:15Z

Thank you for the PR!

ClaudiaComito

Thanks a lot @FOsterfeld , @mrfh92 !

…r_systems

github-actions · 2024-04-12T12:45:32Z

Thank you for the PR!

* solve_triangular from previous pr #1236 * added test for type and value errors --------- Co-authored-by: Claudia Comito <39374113+ClaudiaComito@users.noreply.github.com>

added my first ideas for an implementation of solve_triangular (not a…

8ffa51c

…ll cases covered, may be inefficient, no tests so far!)

mrfh92 mentioned this pull request Oct 10, 2023

Provide a solver for triangular systems #1096

Closed

readme test

8003642

dummy commit to find out whether CI works...

e6c88e8

mrfh92 mentioned this pull request Oct 12, 2023

Update Heat Tutorials, fix typos. #1238

Merged

5 tasks

github-actions bot added the stale label Dec 18, 2023

Merge branch 'main' into features/1096-Provide_a_solver_for_triangula…

782c7b2

…r_systems

github-actions bot removed the stale label Dec 25, 2023

FOsterfeld self-assigned this Jan 2, 2024

Merge branch 'main' into features/1096-Provide_a_solver_for_triangula…

524e294

…r_systems

small improvements in solve_triangular for the case A.split == 1

3749dbf

small improvements in solve_triangular for the case A.split == 0

de2fe73

added tests for solve_triangular

85fd3af

Merge branch 'main' into features/1096-Provide_a_solver_for_triangula…

bcac92e

…r_systems

mrfh92 added PR talk Review me labels Apr 4, 2024

Merge branch 'main' into features/1096-Provide_a_solver_for_triangula…

f790e23

…r_systems

ClaudiaComito requested changes Apr 11, 2024

View reviewed changes

mrfh92 and others added 3 commits April 11, 2024 11:01

Update heat/core/linalg/solver.py

af10937

Co-authored-by: Claudia Comito <39374113+ClaudiaComito@users.noreply.github.com>

Update heat/core/linalg/solver.py

795053f

Co-authored-by: Claudia Comito <39374113+ClaudiaComito@users.noreply.github.com>

Update heat/core/linalg/solver.py

ba3578a

Co-authored-by: Claudia Comito <39374113+ClaudiaComito@users.noreply.github.com>

Update solver.py

e248a42

incorporated @ClaudiaComito's suggestions for docstring

Merge branch 'main' into features/1096-Provide_a_solver_for_triangula…

d9edee7

…r_systems

ClaudiaComito added this to the 1.4.0 milestone Apr 12, 2024

ClaudiaComito changed the title ~~Add solver for triangular systems~~ Add solver for distributed triangular systems Apr 12, 2024

ClaudiaComito approved these changes Apr 12, 2024

View reviewed changes

ClaudiaComito added merge queue and removed PR talk Review me labels Apr 12, 2024

Merge branch 'main' into features/1096-Provide_a_solver_for_triangula…

6589754

…r_systems

mrfh92 merged commit b070199 into main Apr 12, 2024
10 checks passed

mrfh92 deleted the features/1096-Provide_a_solver_for_triangular_systems branch April 12, 2024 13:46

mrfh92 restored the features/1096-Provide_a_solver_for_triangular_systems branch April 15, 2024 10:40

FOsterfeld added a commit that referenced this pull request Jun 1, 2024

solve_triangular from previous pr #1236

8502a17

FOsterfeld mentioned this pull request Jun 1, 2024

Add solver for triangular systems #1504

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add solver for distributed triangular systems #1236

Add solver for distributed triangular systems #1236

mrfh92 commented Oct 10, 2023 •

edited by ClaudiaComito

Loading

ghost commented Oct 10, 2023 •

edited by ghost

Loading

Legend

mrfh92 commented Oct 10, 2023

github-actions bot commented Oct 10, 2023

codecov bot commented Oct 10, 2023 •

edited

Loading

github-actions bot commented Oct 10, 2023

github-actions bot commented Oct 12, 2023

github-actions bot commented Dec 18, 2023

github-actions bot commented Dec 18, 2023

mrfh92 commented Dec 18, 2023 •

edited

Loading

github-actions bot commented Jan 3, 2024

mrfh92 commented Jan 10, 2024

github-actions bot commented Jan 16, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 22, 2024

mrfh92 commented Jan 22, 2024

github-actions bot commented Apr 3, 2024

github-actions bot commented Apr 11, 2024

ClaudiaComito left a comment

github-actions bot commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

mrfh92 commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

ClaudiaComito left a comment

github-actions bot commented Apr 12, 2024

Add solver for distributed triangular systems #1236

Add solver for distributed triangular systems #1236

Conversation

mrfh92 commented Oct 10, 2023 • edited by ClaudiaComito Loading

Due Diligence

ghost commented Oct 10, 2023 • edited by ghost Loading

Legend

mrfh92 commented Oct 10, 2023

github-actions bot commented Oct 10, 2023

codecov bot commented Oct 10, 2023 • edited Loading

Codecov Report

github-actions bot commented Oct 10, 2023

github-actions bot commented Oct 12, 2023

github-actions bot commented Dec 18, 2023

github-actions bot commented Dec 18, 2023

mrfh92 commented Dec 18, 2023 • edited Loading

github-actions bot commented Jan 3, 2024

mrfh92 commented Jan 10, 2024

github-actions bot commented Jan 16, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 22, 2024

mrfh92 commented Jan 22, 2024

github-actions bot commented Apr 3, 2024

github-actions bot commented Apr 11, 2024

ClaudiaComito left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

mrfh92 commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

ClaudiaComito left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 12, 2024

mrfh92 commented Oct 10, 2023 •

edited by ClaudiaComito

Loading

ghost commented Oct 10, 2023 •

edited by ghost

Loading

codecov bot commented Oct 10, 2023 •

edited

Loading

mrfh92 commented Dec 18, 2023 •

edited

Loading