Add solver for triangular systems #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1504 +/- ##
==========================================
+ Coverage 91.74% 91.80% +0.06%
==========================================
Files 80 80
Lines 11683 11772 +89
==========================================
+ Hits 10718 10807 +89
Misses 965 965
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrfh92
changed the title
ClaudiaComito
approved these changes
Jun 5, 2024
|
Thank you for the PR! |
ClaudiaComito
requested changes
Jun 5, 2024
There was a problem hiding this comment.
@FOsterfeld apologies, I just noticed the lines that aren't covered by tests, can we increase the test coverage?
|
Thank you for the PR! |
1 similar comment
|
Thank you for the PR! |
ClaudiaComito
approved these changes
Jun 12, 2024
ClaudiaComito
deleted the
1503-provide-a-solver-for-triangular-systems-new-pr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of the previous PR for solve_triangular #1236 .
to add the context: we had already merged this PR, but then some error with the CI occurred and undid the changes (which were, however, not responsible for this error as we found out later)