Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/240 flipud #496

Merged
merged 18 commits into from
Apr 1, 2020
Merged

Features/240 flipud #496

merged 18 commits into from
Apr 1, 2020

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Mar 10, 2020

Description

Include a summary of the change/s.
Please also include relevant motivation and context. List any dependencies that are required for this change.

Naïve implementation of flipud. It returns a new upside down tensor. Will have redundant code to #498.

Issue/s resolved: #240

Changes proposed:

  • implement flipud

Type of change

Remove irrelevant options:

  • New feature (non-breaking change which adds functionality)
  • Documentation update

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #496 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #496   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files          65       65           
  Lines       14039    14055   +16     
=======================================
+ Hits        13565    13581   +16     
  Misses        474      474           
Impacted Files Coverage Δ
heat/core/manipulations.py 99.23% <100.00%> (+<0.01%) ⬆️
heat/core/tests/test_manipulations.py 99.29% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5604d5...658814b. Read the comment docs.

>>> a = ht.array([[0,1],[2,3]])
>>> ht.flipud(a)
tensor([[2, 3],
[0, 1]])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multi-process example

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example added.
I noticed that the multiprocess examples differ in the formatting. Is there a style guide?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no style guide on this issue. all that matters is that the processes are indicted

coquelin77
coquelin77 previously approved these changes Mar 31, 2020
coquelin77
coquelin77 previously approved these changes Apr 1, 2020
@coquelin77
Copy link
Member

can you resolve the conflicts? the auto-merging doesnt play nice here

@mtar
Copy link
Collaborator Author

mtar commented Apr 1, 2020

I was expecting that as it is mostly the same code

@mtar
Copy link
Collaborator Author

mtar commented Apr 1, 2020

I think the easiest way will be to simply call flip

@coquelin77
Copy link
Member

I think the easiest way will be to simply call flip

that makes sense to me. let me know when the changes are made

@mtar
Copy link
Collaborator Author

mtar commented Apr 1, 2020

All done and ready to merge

@coquelin77 coquelin77 merged commit 2e70431 into master Apr 1, 2020
@coquelin77 coquelin77 deleted the features/240-flipud branch April 1, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide flipup()
2 participants