Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features/239-flip() #498

Merged
merged 10 commits into from
Apr 1, 2020
Merged

features/239-flip() #498

merged 10 commits into from
Apr 1, 2020

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Mar 10, 2020

Description

Include a summary of the change/s.
Please also include relevant motivation and context. List any dependencies that are required for this change.

implementation of flip(). It returns a new flipped tensor.

Issue/s resolved: #239

Changes proposed:

  • implement flip

Type of change

Remove irrelevant options:

  • New feature (non-breaking change which adds functionality)
  • Documentation update

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@mtar mtar changed the title implement flip() features/239-flip() Mar 10, 2020
@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #498 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   96.60%   96.62%   +0.02%     
==========================================
  Files          65       65              
  Lines       13991    14085      +94     
==========================================
+ Hits        13516    13610      +94     
  Misses        475      475              
Impacted Files Coverage Δ
heat/core/manipulations.py 99.23% <100.00%> (+0.02%) ⬆️
heat/core/tests/test_manipulations.py 99.27% <100.00%> (+0.01%) ⬆️
heat/core/factories.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7713b9b...2efb1db. Read the comment docs.

@mtar mtar mentioned this pull request Mar 13, 2020
4 tasks
heat/core/manipulations.py Outdated Show resolved Hide resolved
coquelin77
coquelin77 previously approved these changes Mar 31, 2020
@coquelin77 coquelin77 merged commit a5604d5 into master Apr 1, 2020
@coquelin77 coquelin77 deleted the features/239-flip branch April 1, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide flip()
2 participants