-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added duplicate comm #940
added duplicate comm #940
Conversation
GPU cluster tests are currently disabled on this Pull Request. |
@mtar any changes required? |
Thank you. There is one minor issue: changelog.md needs to be updated under the title "Pending Additions". It might be useful to have a short comment in the code, too. |
@mtar done with changes. |
@mtar can you pls review. |
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
Codecov Report
@@ Coverage Diff @@
## main #940 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 64 64
Lines 9875 9877 +2
=======================================
+ Hits 9428 9430 +2
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@ClaudiaComito any changes are required? |
run tests |
@Dhruv454000 thanks a lot, I just started the tests on GPU, I think all checks will pass afterwards |
run tests |
run tests |
1 similar comment
run tests |
run tests |
@ClaudiaComito is there any issue? |
run tests |
I think the cutoff time was exceeded on the GPU tests, because of the new tests introduced by the latest PR merge. Now the cutoff has been extended and everything works. I'm going to approve and merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Dhruv454000 for taking this on and congratulations on your first contribution here! 👏🏼
Description
Duplicate MPI_COMM_WORLD for the default communicator.
Changes proposed:
Added a duplicate of MPI_COMM_WORLD to make library more independent.