Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate MPI_SELF as well #967

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Conversation

ClaudiaComito
Copy link
Contributor

@ClaudiaComito ClaudiaComito commented Apr 21, 2022

Description

Expanding on #940, not only MPI.COMM_WORLD but also MPI_SELF must be duplicated

Issue/s resolved: #895

Changes proposed:

  • duplicate MPI_SELF

Type of change

  • New feature (non-breaking change which adds functionality)

Memory requirements

Performance

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@ghost
Copy link

ghost commented Apr 21, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #967 (3345abb) into main (4490237) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #967   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          64       64           
  Lines        9898     9898           
=======================================
  Hits         9439     9439           
  Misses        459      459           
Flag Coverage Δ
gpu 94.59% <100.00%> (ø)
unit 90.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/communication.py 96.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4490237...3345abb. Read the comment docs.

@ClaudiaComito ClaudiaComito merged commit febe4fa into main Apr 22, 2022
@ClaudiaComito ClaudiaComito deleted the features/895-duplicate-MPI_SELF branch April 22, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate MPI Communicator
2 participants