hamid/78467/pa-cancel-wizard-dialog

[hamid-deriv]

Changes:

Please include a summary of the change and which issue is fixed below:

• ...

When you need to add unit test

• If this change disrupt current flow
• If this change is adding new flow

When you need to add integration test

• If components from external libraries are being used to define the flow, e.g. @deriv/components
• If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

• Ensure utility / function has a test case
• Ensure all the tests are passing

Type of change

• Bug fix
• New feature
• Update feature
• Refactor code
• Translation to code
• Translation to crowdin
• Script configuration
• Improve performance
• Style only
• Dependency update
• Documentation update
• Release

[heorhi-deriv]

Suggested change

	onConfirm={() => onConfirm()}
	onConfirm={onConfirm}

[farzin-deriv]

@hamid-deriv I think both onConfirm and onCancel can be handled inside this component and there is no need to get them as a prop 🤔

[hamid-deriv]

@farzin-fs visible state will be defined in the wizard component that this component will be used there so that the wizard component will handle the state on close. Also, there are actions in the wizard that should be triggered in the wizard, so I think that it would be easier and more readable to handle the confirm action in the wizard, too.

[heorhi-deriv]

Suggested change

	onCancel={() => onCancel()}
	onCancel={onCancel}

[farzin-deriv]

Suggested change

	onConfirm: () => void;
	onCancel: () => void;
	onConfirm: VoidFunction;
	onCancel: VoidFunction;

@hamid-deriv There is no difference 😅 You can ignore this 🙇🏻

[farzin-deriv]

@hamid-deriv I think both onConfirm and onCancel can be handled inside this component and there is no need to get them as a prop 🤔