Renrender issue #40
Closed
Renrender issue #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heorhi-deriv
pushed a commit
that referenced
this pull request
Oct 6, 2023
…om#8884) * chore: new pr for wall 400 * feat: ✨ incorporated change to display the id document name * chore: country selector warning if failed * fix: ♻️ resolved comments * refactor: css file rename * feat: resolved code smell * refactor: expired and failed different warnings * refactor: failed messaged moved to country selector * chore: 💚 trigger build * refactor: review comments * refactor: review comments css * fix: 🐛 incorporated message to display document type * fix: resolved code smell * fix: 🐛 incorporated generic error message * fix: 🐛 added missing dependency * chore: 🔀 synced with master * fix: ♻️ incorporated review comments * fix: resolved un necessary render issue * fix: 🐛 resolved issue with expired status * style: fix side container width in poi (#39) * style: container height fix for POI error messages when content in not overflowing (#40) * fix: onfido message alignment * fix: 🐛 incorporated continue trade button * fix: onfido page mobile * style: no padding on fields container in idv screen (#41) * refactor: onfido hint center alignment fix * fix: odd translate value fix * fix: 🐛 minor CSS fix * fix: green message responsive position * fix: green message full width * fix: ✅ updated testcases * fix: failing tests * refactor: code and ts fixes * fix: display of IDV error * chore: add duplication account error * refactor: added undefined check to response data * chore: review comments * chore: review comments * fix: ♻️ incorporated review comments * fix: barriers test fix form master * fix: barriers test * chore: refactored object.freeze to as const * chore: optional chaining to document type * chore: update spec file for idv-form * test: update personal-details spec * chore: review comments * refactor: css structure * fix: barriers test * fix: ♻️ incorporated review comments * refactor: rename properties * refactor: remove is_appstore from tests * refactor: styles refactor * fix: ⚡ reduced duplicate data * fix: incorporated review comments * fix: ♻️ incorporated review comments * chore: Trigger Build * fix: 🚚 modified path * chore: remove unused fila and variable, updated icons * revert: 🍻 removed icon changes * refactor: removed formatting * fix: removed assignment of default values * fix: 🐛 unable to select a new doc supporting country * fix: 🐛 resolved re-render issue * fix: ⚡ resolved message issue * refactor: 🚚 renamed varibales * fix: 🧪 failing testcase * fix: 🐛 resolved issues with failure messages * fix: 🐛 resolved issue with DIEL accounts * fix: 🐛 fixed issue for DIEL clients * fix: styling issues * fix: ts error for format-response * fix: 🚚 fixed path * fix: 🚚 fixed path * fix: 🐛 resolved styling bugs * fix: 🐛 resolved styling bugs * fix: 🔥 incorporated new styles to fix icon size * fix: 🔥 incorporated new styles to fix icon size * fix: ✅ fixed failing testcase * fix: 💚 eslint issues * fix: layout styles * fix: style issues * fix: styles * fix: moved common styles to core * fix: 💄 updated styles * refactor: incorporated review comments * Merge branch 'master' into combined/wall-400/IDV-error-message-handled --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com>
heorhi-deriv
pushed a commit
that referenced
this pull request
Nov 4, 2023
* feat: add key files from prev tech tebt branch * feat: add digits file from prev branch * feat: add contract types file from prev branch * feat: add trade params mobile from prev branch * fix: remove duplicates * Maryia/dtra-401/TS migration: multiplier components (#34) * chore: migrate cancel-deal to ts * chore: migrate expiration & expiration modal * chore: migrated multiplier * chore: migrate stop-loss * chore: migrate take-profit * chore: migrate widgets * build: trigger build with empty commit * Kate / DTRA-398 / TS migration: Widget components in Trader package (#33) * refactor: ts of contract replay widget * refactor: ts of mobile widgets * refactor: ts of chart widgets * refactor: ts of top widgets * refactor: ts of top widgets * refactor: types for widgets * refactor: apply suggestions * refactor: add position prop * fix: extention of the imported file * chore: replace some localizes (#36) * Kate / DTRA-400 / [Refactoring]: delete duplicated unused files from Markers folder in Trader package and migrate to TS marker.jsx (#37) * refactor: marker folder * fix: change file extension in test * Kate / DTRA-404 / [Refactoring]: Divide trade-categories.tsx file and cover changes with tests (#35) * refactor: add rise fall description * refactor: separate stay end high contract description * refactor: separate description of digits contracts * refactor: separate asian reset runhighlow touch contracts * refactor: separate callputspread lb tickhighlow and vanilla contracts * refactor: separate multipliers contract * refactor: add unit tests for contract descriptions * refactor: add more tests * refactor: add tests for touch ans vanilla contracts * refactor: tests for trade categories * refactor: contract description structure * refactor: apply suggestions * refactor: add missing test case * Maryia/DTRA-403/feat: migrate Routes files in Trader package to TS (#38) * feat: migrate routes files to ts * fix: routes extension * refactor: for consistency * refactor: import order * refactor: renamed prop types * refactor: type for consistency * refactor: remove index as key * fix: ts migrate settingsmodal and remove unused file (#39) * fix: ts migrate settingsmodal and remove unused file * fix: failing tests * Kate/ fix: code smells (#40) * fix: code smells * chore: empty commit * fix: function arguments * refactor: tests * fix: codesmells * refactor: code smells * chore: change optional chaining * refactor: tests * refactor: tests for widgets component * fix: tests * fix: conflicts * fix: more conflicts * fix: tests * refactor: add more test cases * fix: types in tests * fix: test extention * fix: return turbos back to types * fix: revert unplanned files * fix: code smells (#42) * fix: test extention * fix: bug with inserting objecting into the backticks * fix: file extention after ts migration * chore: sort imports * chore: revert file * chore: revert wallet changes * chore: remove extra file * chore: apply nit * fix: language switching issue with the chart --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com>
heorhi-deriv
pushed a commit
that referenced
this pull request
Nov 8, 2023
* chore: new pr for wall 400 * feat: ✨ incorporated change to display the id document name * chore: country selector warning if failed * fix: ♻️ resolved comments * refactor: css file rename * feat: resolved code smell * refactor: expired and failed different warnings * refactor: failed messaged moved to country selector * chore: 💚 trigger build * refactor: review comments * refactor: review comments css * fix: 🐛 incorporated message to display document type * fix: resolved code smell * fix: 🐛 incorporated generic error message * fix: 🐛 added missing dependency * chore: 🔀 synced with master * fix: ♻️ incorporated review comments * fix: resolved un necessary render issue * fix: 🐛 resolved issue with expired status * style: fix side container width in poi (#39) * style: container height fix for POI error messages when content in not overflowing (#40) * fix: onfido message alignment * fix: 🐛 incorporated continue trade button * fix: onfido page mobile * style: no padding on fields container in idv screen (#41) * refactor: onfido hint center alignment fix * fix: odd translate value fix * fix: 🐛 minor CSS fix * fix: green message responsive position * fix: green message full width * fix: ✅ updated testcases * fix: failing tests * refactor: code and ts fixes * fix: display of IDV error * chore: add duplication account error * refactor: added undefined check to response data * chore: review comments * chore: review comments * fix: ♻️ incorporated review comments * fix: barriers test fix form master * fix: barriers test * chore: refactored object.freeze to as const * chore: optional chaining to document type * chore: update spec file for idv-form * test: update personal-details spec * chore: review comments * refactor: css structure * fix: barriers test * fix: ♻️ incorporated review comments * refactor: rename properties * refactor: remove is_appstore from tests * refactor: styles refactor * fix: ⚡ reduced duplicate data * fix: incorporated review comments * fix: ♻️ incorporated review comments * chore: Trigger Build * fix: 🚚 modified path * chore: remove unused fila and variable, updated icons * revert: 🍻 removed icon changes * refactor: removed formatting * fix: removed assignment of default values * fix: 🐛 unable to select a new doc supporting country * fix: 🐛 resolved re-render issue * fix: ⚡ resolved message issue * refactor: 🚚 renamed varibales * fix: 🧪 failing testcase * fix: 🐛 resolved issues with failure messages * fix: 🐛 resolved issue with DIEL accounts * fix: 🐛 fixed issue for DIEL clients * fix: styling issues * fix: ts error for format-response * fix: 🚚 fixed path * fix: 🚚 fixed path * fix: 🐛 resolved styling bugs * fix: 🐛 resolved styling bugs * fix: 🔥 incorporated new styles to fix icon size * fix: 🔥 incorporated new styles to fix icon size * fix: ✅ fixed failing testcase * fix: 💚 eslint issues * fix: layout styles * fix: style issues * fix: styles * fix: moved common styles to core * fix: 💄 updated styles * refactor: incorporated review comments * Merge branch 'master' into combined/wall-400/IDV-error-message-handled * fix: bug: /WEBREL-1358/personal-details page and poa page css issue * fix: layout button * fix: layout button * fix: mt5 next button not getting enabled * fix: resolved issue with button * fix: resolved issue with button * fix: resolved missing dropdown * fix: removed console * fix: incorporated review comments * feat: ✨ incorporated new images and merged checkbox feature * feat: ✨ incorporated new images and merged checkbox feature * fix: idv failed document type * fix: incorporated error message scenario * fix: styling as per new figma * fix: styling as per new figma * fix: spacing between fields * fix: spacing between fields * fix: spacing between fields * fix: incorporated new error code and styles as per new figma * fix: incorporated new error code and styles as per new figma * Merge branch 'master' into likhith/kyc-195/display-idv-error-messages * fix: code smells * chore: trigger rebuild * fix: issue with checkbox * fix: removed unused import * fix: added keyboard event * fix: resolved build failure --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com>
heorhi-deriv
pushed a commit
that referenced
this pull request
Nov 9, 2023
* refactor: review comments * refactor: review comments css * fix: 🐛 incorporated message to display document type * fix: resolved code smell * fix: 🐛 incorporated generic error message * fix: 🐛 added missing dependency * chore: 🔀 synced with master * fix: ♻️ incorporated review comments * fix: resolved un necessary render issue * fix: 🐛 resolved issue with expired status * style: fix side container width in poi (#39) * style: container height fix for POI error messages when content in not overflowing (#40) * fix: onfido message alignment * fix: 🐛 incorporated continue trade button * fix: onfido page mobile * style: no padding on fields container in idv screen (#41) * refactor: onfido hint center alignment fix * fix: odd translate value fix * fix: 🐛 minor CSS fix * fix: green message responsive position * fix: green message full width * fix: ✅ updated testcases * fix: failing tests * refactor: code and ts fixes * fix: display of IDV error * chore: add duplication account error * refactor: added undefined check to response data * chore: review comments * chore: review comments * fix: ⬆️ upgraded SDK and handled language change * fix: ♻️ incorporated review comments * fix: ♻️ refactored code to remove useRef * fix: barriers test fix form master * fix: barriers test * chore: refactored object.freeze to as const * chore: optional chaining to document type * chore: update spec file for idv-form * test: update personal-details spec * chore: review comments * refactor: ♻️ incorporated hooks to handle business logic * refactor: css structure * fix: barriers test * fix: ⚰️ removed unwanted code * test: 🔥 removed mocked tokens * chore: 📝 Added documentation for UseNotificationEvent hook * fix: 💄 incorporated styling * fix: ♻️ incorporated review comments * refactor: rename properties * refactor: remove is_appstore from tests * fix: ♻️ incorporated review comments * refactor: styles refactor * fix: ⚡ reduced duplicate data * fix: incorporated review comments * fix: ♻️ incorporated review comments * chore: Trigger Build * fix: 🚚 modified path * chore: remove unused fila and variable, updated icons * revert: 🍻 removed icon changes * refactor: removed formatting * fix: removed assignment of default values * fix: 🐛 unable to select a new doc supporting country * fix: 🐛 resolved re-render issue * fix: ⚡ resolved message issue * refactor: 🚚 renamed varibales * fix: 🧪 failing testcase * fix: 🐛 resolved issues with failure messages * fix: 🐛 resolved issue with DIEL accounts * fix: 🐛 fixed issue for DIEL clients * fix: styling issues * fix: ts error for format-response * build: 📌 updated package-lock after updating onfido-sdk-ui * fix: 🚚 fixed path * fix: 🚚 fixed path * fix: 🐛 resolved styling bugs * fix: 🐛 resolved styling bugs * fix: ♻️ removed default values * fix: 🔥 incorporated new styles to fix icon size * fix: 🔥 incorporated new styles to fix icon size * fix: ✅ fixed failing testcase * fix: 💚 eslint issues * fix: ⚡ incorporated platform language change * fix: removed store * fix: layout styles * fix: style issues * fix: styles * fix: moved common styles to core * refactor: incorporated review comments * fix: 💄 updated styles * fix: 🐛 reverted code * fix: 🐛 reverted code * refactor: incorporated review comments * fix: 🐛 Onfido SDK language code conversion * fix: migrated hooks * revert: logic for generating code * chore: adding missing testcases * fix: recatored Onfido constants * fix: onfido screen css issues * fix: removed package-lock to resolve merge error * Merge branch 'master' into likhith/KYC-363/onfido-sdk-updation * chore: added package-lock * Merge branch 'master' into combined/wall-400/IDV-error-message-handled * chore: Trigger Build * fix: bug: /WEBREL-1358/personal-details page and poa page css issue * fix: layout button * fix: layout button * fix: mt5 next button not getting enabled * fix: resolved issue with button * fix: resolved issue with button * fix: resolved missing dropdown * fix: removed console * fix: incorporated review comments * feat: ✨ incorporated new images and merged checkbox feature * feat: ✨ incorporated new images and merged checkbox feature * fix: idv failed document type * fix: removed duplicate import * fix: incorporated error message scenario * fix: styling as per new figma * fix: styling as per new figma * fix: spacing between fields * fix: spacing between fields * fix: spacing between fields * fix: incorporated new error code and styles as per new figma * fix: incorporated new error code and styles as per new figma * Merge branch 'master' into likhith/kyc-195/display-idv-error-messages * fix: reverted changes * Incorporate poi context (binary-com#55) * chore: incorporate POIContext to keep track of submission * chore: reset poi context state upon route change * refactor: added reset for all path * fix: changed testcases --------- Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> * fix: code smells * chore: trigger rebuild * fix: issue with checkbox * fix: removed unused import * fix: added keyboard event * fix: resolved build failure * Merge branch 'master' into likhith/KYC-363/onfido-sdk-updation * fix: Onfido styles * fix: resolved code-smells --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com>
heorhi-deriv
pushed a commit
that referenced
this pull request
Nov 16, 2023
* chore: new pr for wall 400 * feat: ✨ incorporated change to display the id document name * chore: country selector warning if failed * fix: ♻️ resolved comments * refactor: css file rename * feat: resolved code smell * refactor: expired and failed different warnings * refactor: failed messaged moved to country selector * chore: 💚 trigger build * refactor: review comments * refactor: review comments css * fix: 🐛 incorporated message to display document type * fix: resolved code smell * fix: 🐛 incorporated generic error message * fix: 🐛 added missing dependency * chore: 🔀 synced with master * fix: ♻️ incorporated review comments * fix: resolved un necessary render issue * fix: 🐛 resolved issue with expired status * style: fix side container width in poi (#39) * style: container height fix for POI error messages when content in not overflowing (#40) * fix: onfido message alignment * fix: 🐛 incorporated continue trade button * fix: onfido page mobile * style: no padding on fields container in idv screen (#41) * refactor: onfido hint center alignment fix * fix: odd translate value fix * fix: 🐛 minor CSS fix * fix: green message responsive position * fix: green message full width * fix: ✅ updated testcases * fix: failing tests * refactor: code and ts fixes * fix: display of IDV error * chore: add duplication account error * refactor: added undefined check to response data * chore: review comments * chore: review comments * fix: ♻️ incorporated review comments * fix: barriers test fix form master * fix: barriers test * chore: refactored object.freeze to as const * chore: optional chaining to document type * chore: update spec file for idv-form * test: update personal-details spec * chore: review comments * refactor: css structure * fix: barriers test * fix: ♻️ incorporated review comments * refactor: rename properties * refactor: remove is_appstore from tests * refactor: styles refactor * fix: ⚡ reduced duplicate data * fix: incorporated review comments * fix: ♻️ incorporated review comments * chore: Trigger Build * fix: 🚚 modified path * chore: remove unused fila and variable, updated icons * revert: 🍻 removed icon changes * refactor: removed formatting * fix: removed assignment of default values * fix: 🐛 unable to select a new doc supporting country * fix: 🐛 resolved re-render issue * fix: ⚡ resolved message issue * refactor: 🚚 renamed varibales * fix: 🧪 failing testcase * fix: 🐛 resolved issues with failure messages * fix: 🐛 resolved issue with DIEL accounts * fix: 🐛 fixed issue for DIEL clients * fix: styling issues * fix: ts error for format-response * fix: 🚚 fixed path * fix: 🚚 fixed path * fix: 🐛 resolved styling bugs * fix: 🐛 resolved styling bugs * fix: 🔥 incorporated new styles to fix icon size * fix: 🔥 incorporated new styles to fix icon size * fix: ✅ fixed failing testcase * fix: 💚 eslint issues * fix: layout styles * fix: style issues * fix: styles * fix: moved common styles to core * fix: 💄 updated styles * refactor: incorporated review comments * Merge branch 'master' into combined/wall-400/IDV-error-message-handled * fix: bug: /WEBREL-1358/personal-details page and poa page css issue * fix: layout button * fix: layout button * fix: mt5 next button not getting enabled * fix: resolved issue with button * fix: resolved issue with button * fix: resolved missing dropdown * fix: removed console * fix: incorporated review comments * feat: ✨ incorporated new images and merged checkbox feature * feat: ✨ incorporated new images and merged checkbox feature * fix: idv failed document type * fix: incorporated error message scenario * fix: styling as per new figma * fix: styling as per new figma * fix: spacing between fields * fix: spacing between fields * fix: spacing between fields * fix: incorporated new error code and styles as per new figma * fix: incorporated new error code and styles as per new figma * Merge branch 'master' into likhith/kyc-195/display-idv-error-messages * fix: code smells * chore: trigger rebuild * fix: issue with checkbox * feat: added hint text and updated label text for Uganda * chore: trigger build * fix: 💫 added translation for Additional document * fix: sub task COJ-209 * fix: sub task COJ-209 --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com>
heorhi-deriv
pushed a commit
that referenced
this pull request
Nov 30, 2023
…-com#10942) * style: fix side container width in poi (#39) * style: container height fix for POI error messages when content in not overflowing (#40) * fix: onfido message alignment * fix: 🐛 incorporated continue trade button * fix: onfido page mobile * style: no padding on fields container in idv screen (#41) * refactor: onfido hint center alignment fix * fix: odd translate value fix * fix: 🐛 minor CSS fix * fix: green message responsive position * fix: green message full width * fix: ✅ updated testcases * fix: failing tests * refactor: code and ts fixes * fix: display of IDV error * chore: add duplication account error * refactor: added undefined check to response data * chore: review comments * chore: review comments * fix: ⬆️ upgraded SDK and handled language change * fix: ♻️ incorporated review comments * fix: ♻️ refactored code to remove useRef * fix: barriers test fix form master * fix: barriers test * chore: refactored object.freeze to as const * chore: optional chaining to document type * chore: update spec file for idv-form * test: update personal-details spec * chore: review comments * refactor: ♻️ incorporated hooks to handle business logic * refactor: css structure * fix: barriers test * fix: ⚰️ removed unwanted code * test: 🔥 removed mocked tokens * chore: 📝 Added documentation for UseNotificationEvent hook * fix: 💄 incorporated styling * fix: ♻️ incorporated review comments * refactor: rename properties * refactor: remove is_appstore from tests * fix: ♻️ incorporated review comments * refactor: styles refactor * fix: ⚡ reduced duplicate data * fix: incorporated review comments * fix: ♻️ incorporated review comments * chore: Trigger Build * fix: 🚚 modified path * chore: remove unused fila and variable, updated icons * revert: 🍻 removed icon changes * refactor: removed formatting * fix: removed assignment of default values * fix: 🐛 unable to select a new doc supporting country * fix: 🐛 resolved re-render issue * fix: ⚡ resolved message issue * refactor: 🚚 renamed varibales * fix: 🧪 failing testcase * fix: 🐛 resolved issues with failure messages * fix: 🐛 resolved issue with DIEL accounts * fix: 🐛 fixed issue for DIEL clients * fix: styling issues * fix: ts error for format-response * build: 📌 updated package-lock after updating onfido-sdk-ui * fix: 🚚 fixed path * fix: 🚚 fixed path * fix: 🐛 resolved styling bugs * fix: 🐛 resolved styling bugs * fix: ♻️ removed default values * fix: 🔥 incorporated new styles to fix icon size * fix: 🔥 incorporated new styles to fix icon size * fix: ✅ fixed failing testcase * fix: 💚 eslint issues * fix: ⚡ incorporated platform language change * fix: removed store * fix: layout styles * fix: style issues * fix: styles * fix: moved common styles to core * refactor: incorporated review comments * fix: 💄 updated styles * fix: 🐛 reverted code * fix: 🐛 reverted code * refactor: incorporated review comments * fix: 🐛 Onfido SDK language code conversion * fix: migrated hooks * revert: logic for generating code * chore: adding missing testcases * fix: recatored Onfido constants * fix: onfido screen css issues * fix: removed package-lock to resolve merge error * Merge branch 'master' into likhith/KYC-363/onfido-sdk-updation * chore: added package-lock * Merge branch 'master' into combined/wall-400/IDV-error-message-handled * chore: Trigger Build * fix: bug: /WEBREL-1358/personal-details page and poa page css issue * fix: layout button * fix: layout button * fix: mt5 next button not getting enabled * fix: resolved issue with button * fix: resolved issue with button * fix: resolved missing dropdown * fix: removed console * fix: incorporated review comments * feat: ✨ incorporated new images and merged checkbox feature * feat: ✨ incorporated new images and merged checkbox feature * fix: idv failed document type * fix: removed duplicate import * fix: incorporated error message scenario * fix: styling as per new figma * fix: styling as per new figma * fix: spacing between fields * fix: spacing between fields * fix: spacing between fields * fix: incorporated new error code and styles as per new figma * fix: incorporated new error code and styles as per new figma * Merge branch 'master' into likhith/kyc-195/display-idv-error-messages * fix: reverted changes * Incorporate poi context (binary-com#55) * chore: incorporate POIContext to keep track of submission * chore: reset poi context state upon route change * refactor: added reset for all path * fix: changed testcases --------- Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> * feat: added message for High risk * refactor: incorporated review comment * fix: added the right check for high-risk * refactor: incorporated review comments * fix: resolved issues pointed out in sonar-cloud * fix: code smells * chore: trigger rebuild * fix: issue with checkbox * fix: added CSS changes to resolve the spacing * fix: added CSS changes to resolve the spacing * fix: removed unused import * fix: added keyboard event * fix: resolved build failure * Merge branch 'master' into likhith/KYC-363/onfido-sdk-updation * fix: Onfido styles * fix: resolved code-smells * fix: Content changes --------- Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed. |
heorhi-deriv
pushed a commit
that referenced
this pull request
Apr 1, 2024
…inary-com#12587) * feat: Passkeys init commit * trigger build * fix: resolve conflicts, update package lock * chore: test for useIsPasskeySupported hook * chore: restore jest config * chore: remove unneccesary comment * chore: hook code refactor * chore: upm-405,upm-407,upm-408: not set screen, lern more screen, fetch hook * chore: review comments, fix for jest config * fix: types error * refactor: review comments * refactor: move get passkeys key hook to hooks from api * refactor: remove quill * chore: register passkey, passkeys-list * fix: publicKeyCredential type * chore: added passkey icons * chore: learnmore back button, passkey list css * chore: refactor flow, added status content, styles fix * chore: added name to passkey_register * chore: register request fix * chore: update not-set page * chore: success page content update * chore: added console logs * chore: update icons * chore: code refactor, updates with design * chore: tests for components, code refactor * chore: useregister refactor * fix: unnecessary fragment remove * fix: mock passkey remove * refactor: status handling, test cases * fix: time calculation, consolelog remove * fix: last_used name field * chore: added console log for tracking registration errors * chore: initial test for useRegisterPasskey * chore: passkey modal for errors add * chore: added modal to status component * chore: new icon * chore: effortless login page content * chore: status wrapper refactor * chore: error content config init * chore: removed modal from status component * chore: remove route function refactor, context value removed * chore: error flow and show in modal * chore: style fix for error content * chore: useregister passkey refactor * refactor: content change, hook refactor * chore: never used passkey * chore: implement reload logic * refactor: remove usequery for registration * chore: is passkey_supported fix * chore: test fix, udpate content * Suisin/chore: create effortless login modal (#40) * chore: create effortless login modal * chore: update test case for effortless login modal * chore: learn more effortless login, useshowmodal refactor * chore: fix tests, removed test for useregister * chore: first login modal logic refactor * chore: show effortless page tests * refactor: register hook new logic with additional step, tests * chore: new creation flow * chore: update design * fix: test cases * chore: unnesesary code line remove * chore: review comments * chore: add feature flag for passkeys using growthbook (#41) * chore: add feature flag for passkeys using growthbook * feat: add growthbook feature flag handling * test: modify testcases for useIsPasskeySupported hook * feat: add a condition to check if growthbook feature i loaded and then trigger checkPaaskeySupport * fix: remove comment * fix: remove typecasting and use git add . instead * fix: typo * chore: review comments part 1 * chore: review comments part 2 * fix: growthbook fetching value * chore: null case for passkey feature flag * chore: review comments * chore: review comments * chore: remove isPasskeySupported hook, added logic to client store * fix: test cases * fix: show modal hook test * fix: load passkey list when the feature is off on BE * fix: modal text blinckig, css full height * chore: switch off feature flag, add delay for closing modal * fix: close reminder modal before creation * fix: failing test * chore: feature flag fetching * fix: bullets color for darkmode * chore: exclude errors coming from terminating process by user side * chore: separate root for effortless modal, added network status pop up * chore: trigger build * fix: tests, modal opening * fix: effortless modal in signup, tests * chore: fix modal appearing * fix: analytics connection trigger * fix: move effortless ,odal logic to client store * fix: test for effortless modal * chore: well-known files update --------- Co-authored-by: Sui Sin <103026762+suisin-deriv@users.noreply.github.com> Co-authored-by: utkarsha-deriv <125863995+utkarsha-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.