-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update printing style #252
Conversation
I like that this PR adds the Current output
New output
Not a blocker, but would it perhaps make sense to consider ways the new output can retain some of the expressiveness of the current output, and still fit the new style? Maybe something like:
or
|
By default Rust's `fs` module does not include the filename when an error is returned. The `fs_err` crate adds filenames back in.
While the name of the buildpack "Procfile Buildpack" hints that it's looking at a Procfile, be specific with the value.
The output `(none)` is not a full sentence. This explains that the buildpack saw an empty file (not entirely true, it could be an error or mis-parse, but there's an open issue for that) and as a result defined no processes.
## heroku/procfile ### Changed - Build output style updated to `bullet_stream`. Output now also includes the commands that were pulled from the `Procfile` in the output. ([#252](heroku/buildpacks-procfile#252))
This updates the Procfile to the
bullet_stream
style of bulletpoint text. The Output has changed to include the command being pulled from the Procfile