Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant create-docker-config CI step #252

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Jun 4, 2022

Since it's no longer required for CI to pass (I couldn't find the exact reason why it was added, since it was undocumented, but I believe Pack used to not handle a missing config well).

Since it's no longer required.
@edmorley edmorley self-assigned this Jun 4, 2022
@edmorley edmorley requested a review from a team as a code owner June 4, 2022 17:02
Copy link
Member

@joshwlewis joshwlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I found myself wondering about this step too. I'm sure there was a reason once upon a time!

@joshwlewis joshwlewis merged commit 2a87642 into main Jun 6, 2022
@joshwlewis joshwlewis deleted the edmorley/rm-create-docker-config branch June 6, 2022 14:56
heroku-linguist bot added a commit that referenced this pull request Dec 20, 2024
## heroku/procfile

### Changed

- Build output style updated to `bullet_stream`. Output now also includes the commands that were pulled from the `Procfile` in the output. ([#252](heroku/buildpacks-procfile#252))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants