feat: add nacos registry #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baiyutang
reviewed
Aug 16, 2022
li-jin-gou
reviewed
Aug 17, 2022
li-jin-gou
reviewed
Aug 22, 2022
li-jin-gou
reviewed
Aug 22, 2022
li-jin-gou
reviewed
Aug 22, 2022
Skyenought
force-pushed
the
main
branch
2 times, most recently
from
1d917eb to
2ffa138
Compare
baiyutang
reviewed
Aug 23, 2022
li-jin-gou
reviewed
Aug 23, 2022
Skyenought
force-pushed
the
main
branch
3 times, most recently
from
e39b97b to
ff2a849
Compare
li-jin-gou
reviewed
Aug 24, 2022
Skyenought
force-pushed
the
main
branch
4 times, most recently
from
a0fa2fb to
cfb975b
Compare
baiyutang
reviewed
Aug 24, 2022
baiyutang
reviewed
Aug 26, 2022
Skyenought
force-pushed
the
main
branch
2 times, most recently
from
d102437 to
200fffb
Compare
li-jin-gou
approved these changes
Aug 27, 2022
zstone12
reviewed
Aug 27, 2022
zstone12
approved these changes
Aug 27, 2022
Haswf
pushed a commit
to Haswf/registry
that referenced
this pull request
Aug 28, 2022
* feat: add nacos registry
li-jin-gou
pushed a commit
that referenced
this pull request
Aug 28, 2022
…#16) * feat: add eureka registry * feat: add eureka resolver * style: run gofumpt * test: add test cases * feat: zookeeper init code * chore: simplify dupliate code && no eps return nil * style: import style * chore: remove utils/entity folder && use Localp * fix: typo * chore: change basic -> standard * refactor: use local utils to get ipv4Address * fix: add cacheKey * test: unit test assert nil * style: add license header * fix: handle host :: case * doc: add compatibility part * refactor: use Localp instead of local utils * test: add assert for reslove * test: add test with hertz * style: add license header && gofumpt * style: add newline to end of file * doc: optimize README.md format * fix: handle host :: case && optimize getInstances code * fix: resolver & licences typo * test: merge test file && remove judge len(ep) * doc: first letter upper * fix: lint error * feat: optimize buildPath code * style: add comment for test func * style: license folders name typo (#11) * fix: sleep time change to 2s (#12) * feat: add polaris registry (#9) * feat: add polaris registry * docs: doc optimization * feat: add nacos registry (#7) * feat: add nacos registry * feat: finish etcd register and resolver * feat: add register * doc: add README.md * test: add eureka service to tests.yml * test: add eureka service to tests.yml * doc: remove Makefile as it's no long required * test: fix data race * test: add test case for local ip * doc: capitalise title * test: fix data race * test: remove local ip test case * fix: use SplitHostPort * style: remove extra new line Co-authored-by: zstone12 <522089185@qq.com> Co-authored-by: rogerogers <40619032+rogerogers@users.noreply.github.com> Co-authored-by: skyenought <70408571+Skyenought@users.noreply.github.com> Co-authored-by: qiuyuyin <56574474+qiuyuyin@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
featt: add nacos registry
Which issue(s) this PR fixes:
Todo: