feat(workerd): use vite/module-runner from peer dep
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hi-ogawa
changed the title
vite/module-runnervite/module-runner from peer dep
hi-ogawa
commented
Oct 27, 2024
Comment on lines
+96
to
+97
| // avoid new AsyncFunction during import side effect | ||
| ).replace(`new AsyncFunction("a", "b", body).toString()`, `""`); |
There was a problem hiding this comment.
Otherwise we get:
service core:user:: Uncaught Error: EvalError: Code generation from strings disallowed for this context
at vite/module-runner:21:37
at vite/module-runner:24:3
error when starting dev server:
MiniflareCoreError [ERR_RUNTIME_FAILURE]: The Workers runtime failed to start. There is likely additional logging output above.
at #assembleAndUpdateConfig (/home/hiroshi/code/personal/vite-environment-examples/node_modules/.pnpm/miniflare@3.20240925.0/node_modules/miniflare/dist/src/index.js:9828:13)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Mutex.runWith (/home/hiroshi/code/personal/vite-environment-examples/node_modules/.pnpm/miniflare@3.20240925.0/node_modules/miniflare/dist/src/index.js:3627:16)
at async #waitForReady (/home/hiroshi/code/personal/vite-environment-examples/node_modules/.pnpm/miniflare@3.20240925.0/node_modules/miniflare/dist/src/index.js:9885:5)
at async Miniflare2._getProxyClient (/home/hiroshi/code/personal/vite-environment-examples/node_modules/.pnpm/miniflare@3.20240925.0/node_modules/miniflare/dist/src/index.js:10009:5)
at async #getProxy (/home/hiroshi/code/personal/vite-environment-examples/node_modules/.pnpm/miniflare@3.20240925.0/node_modules/miniflare/dist/src/index.js:10069:25)
at async createWorkerdDevEnvironment (file:///home/hiroshi/code/personal/vite-environment-examples/packages/workerd/dist/index.js:190:14)
at async _createServer (file:///home/hiroshi/code/personal/vite-environment-examples/node_modules/.pnpm/vite@https+++pkg.pr.new+vite@70bb8de_@types+node@20.14.11_terser@5.31.3/node_modules/vite/dist/node/chunks/dep-DsfahqHZ.js:51979:26)
at async CAC.<anonymous> (file:///home/hiroshi/code/personal/vite-environment-examples/node_modules/.pnpm/vite@https+++pkg.pr.new+vite@70bb8de_@types+node@20.14.11_terser@5.31.3/node_modules/vite/dist/node/cli.js:745:20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.