fix(module-runner): delay function eval until module runner instantiation #18480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While trying to avoid bundling
vite/module-runnerin my workerd package hi-ogawa/vite-environment-examples#143, I found thatnew AsyncFunction('a', 'b', body)executed during import side effect causes an error since normal eval is not supported in the environment.In hi-ogawa/vite-environment-examples#143, I manually removed
new AsyncFunctionfrom the source code to make it work. Though I'm not sure we'll be recommending not bundling module runner, delaying this function eval won't probably hurt anything.I tested with a local build and confirmed that
new AsyncFunctionremoval isn't necessary after this change.