Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WG United UI/UX Menu Change #1007

Open
wants to merge 2,282 commits into
base: main
Choose a base branch
from
Open

WG United UI/UX Menu Change #1007

wants to merge 2,282 commits into from

Conversation

sf-pixel
Copy link
Contributor

Menu changes proposed + designed during hicathon added. (Live Demo)

Added:

Notes:

  • Font is Iosevka extended
  • New theme variable added (--divider-color, used for the dividers and hover circles around the menu)
  • Menu closes on external click
  • Footer is floating, fixed on mobile
  • Alias now appears (only if the user logged-in has SUBJKT set)
  • Identicon (or SUBJKT icon) is shown if user is logged in
  • If not logged in, general user icon is shown
  • When open, body overflow is hidden to prevent false scrolls, scroll jumps (mobile only)
  • If NOT logged in, only features that a user without a wallet is listed

Screenshots:

image
image
image
image

image
image
image
image

image
image
image
image

crzypatchwork and others added 30 commits June 12, 2021 08:04
@crzypatchwork
Merge pull request hicetnunc2000#868 from spruceid/develop
061ca75 
Feature - Add Tezos Profiles Verifications for Creators
@crzypatchwork
Merge pull request hicetnunc2000#861 from kylegrover/react-pdf
34cf9ca 
implement react-pdf
@violetforest
Merge branch 'develop', remote-tracking branch 'upstream/develop' int…
ea31cd7 
…o main
@kylegrover
Update w.json
98db8f8
@crzypatchwork
Update w.json
2c19909
@andrevenancio
eslint
4b6db40
@andrevenancio
Merge branch 'develop' of ssh://github.com/hicetnunc2000/hicetnunc in…
9331efb 
…to develop
@andrevenancio
Merge branch 'main' into develop
a98fb10 
# Conflicts:
#	package-lock.json
#	src/pages/mint/index.js
@andrevenancio
commenting unused method, installing compressor on develop branch
62ec391
@andrevenancio
improving objkt detail visibility and scaling
c6ac8f3
@kylegrover
Update w.json
395f012
@crzypatchwork
latest
d422608
@crzypatchwork
revert subjkt
a14c0ef
@kylegrover
Update w.json
e2c8372
@dependabot
Bump read-json-lines-sync from 2.1.6 to 2.1.7
eb905ef 
Bumps [read-json-lines-sync](https://github.com/oprogramador/read-json-lines-sync) from 2.1.6 to 2.1.7.
- [Release notes](https://github.com/oprogramador/read-json-lines-sync/releases)
- [Changelog](https://github.com/oprogramador/read-json-lines-sync/blob/master/.releaserc)
- [Commits](oprogramador/read-json-lines-sync@v2.1.6...v2.1.7)

---
updated-dependencies:
- dependency-name: read-json-lines-sync
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump @testing-library/jest-dom from 5.13.0 to 5.14.1
eb936f6 
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.13.0 to 5.14.1.
- [Release notes](https://github.com/testing-library/jest-dom/releases)
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md)
- [Commits](testing-library/jest-dom@v5.13.0...v5.14.1)

---
updated-dependencies:
- dependency-name: "@testing-library/jest-dom"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@andrevenancio
fix api prop name change bug
e138a67
@andrevenancio
Merge pull request hicetnunc2000#880 from hicetnunc2000/dependabot/np…
2514837 
…m_and_yarn/testing-library/jest-dom-5.14.1

Bump @testing-library/jest-dom from 5.13.0 to 5.14.1
@andrevenancio
Merge pull request hicetnunc2000#879 from hicetnunc2000/dependabot/np…
080e5df 
…m_and_yarn/read-json-lines-sync-2.1.7

Bump read-json-lines-sync from 2.1.6 to 2.1.7
@markknol
Update w.json
2c54333 
missing comma
@crzypatchwork
Merge pull request hicetnunc2000#882 from markknol/patch-1
4c5be59 
Update w.json
@andrevenancio
allow GLB OBJKT to render on feeds.
37edca4
@andrevenancio
Merge branch 'main' of ssh://github.com/hicetnunc2000/hicetnunc into …
066221b 
…main
@crzypatchwork
warning
b4ff064
@crzypatchwork
gltf
a6b8992
@crzypatchwork
latest
0db2ff6
@andrevenancio
removing unecessary component
513f53e
@andrevenancio
sync
a30e33c
@crzypatchwork
filter
a84e35d
@kylegrover
restrict copymint objkts
927102a
@jonnyscholes jonnyscholes mentioned this pull request Jul 20, 2021
Closed
jonnyscholes
jonnyscholes reviewed Jul 20, 2021
View reviewed changes
Copy link

@jonnyscholes jonnyscholes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this new menu!

New design worked well across everything I tested on - see below:

Chrome 91 - MacOS Laptop and Android Pixel 3
Safari 14 - MacOS Laptop
Firefox 90 - MacOS Laptop

I added a couple of accessibility comments, small wins :)

Only UI query I have is using the profile picture as the menu dropdown. Usually clicking a profile button would take you to a profile page. Was a dedicated menu icon considered?

Hope you don't mind the un-invited review - just trying to help where I can :)

src/components/button-theme/styles.module.scss Outdated Show resolved Hide resolved
src/components/icons/styles.module.scss Outdated Show resolved Hide resolved
@sf-pixel
Copy link
Contributor Author

Only UI query I have is using the profile picture as the menu dropdown. Usually clicking a profile button would take you to a profile page. Was a dedicated menu icon considered?

Hope you don't mind the un-invited review - just trying to help where I can :)

I'm working on the accessibility changes as we speak, I'm not sure about the menu icons since this was determined before I joined the WG UI/UX. For now, I think the reason that the SUBJKT icons were added was just a touch of personalization. I'm totally down for the dedicated menu icon, I'll bring it up in the channel #hicathon-ui-ux in the discord to see if the others agree or not. I'm always one for feedback and reviews :)

@sf-pixel sf-pixel mentioned this pull request Jul 23, 2021
Open
22 tasks
@clayheaton
Copy link
Contributor

It's worth noting that the redesigned menu should reduce calls to the API, hopefully contributing to increased stability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnyscholes jonnyscholes jonnyscholes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.