Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/header profile action #994

Conversation

jonnyscholes
Copy link

I regularly click the wallet preview expecting to goto my profile, but nothing happens. Hovering makes it look like a link, so it feels odd that nothing happens.

This PR links the wallet preview to the profile page of the synced wallet. I have decoupled the unsync from the profile button. Instead it now exists as a separate button to the left of the wallet preview when the menu is opened.

Removed some CSS that didnt seem to be used anywhere whilst I was here (.hamburger code).

Screen Shot 2021-07-10 at 11 25 10 pm

@kylegrover
Copy link
Collaborator

had the same thought recently! glad someone decided to do something about it.
I'm not sure if the decoupling part is an improvement though, and it might even cause problems on mobile. but definitely yes to the linking, and yes to the code cleanup

@jonnyscholes
Copy link
Author

Sure, it worked ok down to 375px, but your right below that it got too cramped.

I've reverted it to be much closer to what it was, but with the wallet preview still being a link 🙂

@jonnyscholes
Copy link
Author

Closing this in favour of #1007 which covers this off :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants