New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initialDates shift bug #77

Merged

hoangnm merged 1 commit into hoangnm:master from pdpino:bug/initial-dates

Apr 16, 2021

Collaborator

pdpino commented Apr 16, 2021 •

edited

Loading

Fixes #76

Now the initialDates array contains the correct initial dates from each page, which did not occur before if numberOfDays was 7
Now the "decision" to start a week on Mondays gets relegated to the calculatePagesDates() method, and calculateDaysArray is simplified


          Fix initialDates shift bug

e72c11f

pdpino mentioned this pull request

Feature: add now-line #78

Merged

Owner

hoangnm commented Apr 16, 2021

I see, we missed this when refactored the code. Thanks, @pdpino, merging.

hoangnm merged commit 0a583a5 into hoangnm:master

pdpino deleted the bug/initial-dates branch

April 17, 2021 21:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet