Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add now-line #78

Merged
merged 7 commits into from
Apr 22, 2021
Merged

Feature: add now-line #78

merged 7 commits into from
Apr 22, 2021

Conversation

pdpino
Copy link
Collaborator

@pdpino pdpino commented Apr 16, 2021

Fixes #73

Adds a now-line, which is a red line with a circle to the left, indicating the time right now (see screenshots in the issue).

  • Adds two props: showNowLine and nowLineColor
  • The line gets updated every minute, with a setInterval function
  • Needs to be merged after Fix initialDates shift bug #77 (needs that bug fix to work)

@pdpino pdpino changed the title Feature/line now Feature: add now-line Apr 16, 2021
src/NowLine/NowLine.js Outdated Show resolved Hide resolved
Remove redundant overflow visible
Set useNativeDriver true and isInteraction false
@hoangnm hoangnm merged commit 8d89f16 into hoangnm:master Apr 22, 2021
@pdpino pdpino deleted the feature/line-now branch April 22, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to use the red line at current time like in default diary in iOS?
2 participants