fix(web): Don't parse empty tags in netscape imports. Fixes #421

hoarder-app · Sep 26, 2024 · 4db50c2 · 4db50c2
1 parent 12d3371
commit 4db50c2
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/apps/web/lib/importBookmarkParser.ts b/apps/web/lib/importBookmarkParser.ts
@@ -24,15 +24,17 @@ export async function parseNetscapeBookmarkFile(
       const $a = $(a);
       const addDate = $a.attr("add_date");
       let tags: string[] = [];
+
+      const tagsStr = $a.attr("tags");
       try {
-        tags = $a.attr("tags")?.split(",") ?? [];
+        tags = tagsStr && tagsStr.length > 0 ? tagsStr.split(",") : [];
       } catch (e) {
         /* empty */
       }
       return {
         title: $a.text(),
         url: $a.attr("href"),
-        tags: tags,
+        tags,
         addDate: typeof addDate === "undefined" ? undefined : parseInt(addDate),
       };
     })
@@ -60,7 +62,7 @@ export async function parsePocketBookmarkFile(
       return {
         title: $a.text(),
         url: $a.attr("href"),
-        tags: tags,
+        tags,
         addDate: typeof addDate === "undefined" ? undefined : parseInt(addDate),
       };
     })