Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Importing bookmarks adds all tags to all bookmarks #421

Closed
phampyk opened this issue Sep 25, 2024 · 5 comments
Closed

[Bug Report] Importing bookmarks adds all tags to all bookmarks #421

phampyk opened this issue Sep 25, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@phampyk
Copy link

phampyk commented Sep 25, 2024

I wanted to importa all of my raindrop bookmarks into hoarder, it was around 500 to 600 bookmarks in total... The problem is that it added random tags to the bookmarks, and a lot of them... if not all, I even had some repeating bookmarks already on hoarder that were added onto the "imported bookmarks" list and it added all the extra bookmarks too.
Now my hoarder is really sluggish and even completely froze my machine.

I imported the bookmarks with an HTML file, I can provide the file if you want, generated from a raindrop backup.

image

Same bookmarks in all of the imported bookmarks.


image

All the imported bookmarks have what's basically all the tags I had on hoarder.


image

If I already had the bookmark previously, it added all the extra tags to them as well.

@kamtschatka
Copy link
Collaborator

The last point is expected, i guess. Since it already exists, it will simply be updated.
The rest of course does not make any sense. Can you provide the file somehow? Can you maybe share it with me in discord? Or if you don't mind it being public, then upload it somewhere?

@kamtschatka kamtschatka added the bug Something isn't working label Sep 25, 2024
kamtschatka added a commit to kamtschatka/hoarder-app that referenced this issue Sep 25, 2024
…er-app#421

fixed an issue that caused all existing tags to be assigned to a new bookmark
@kamtschatka
Copy link
Collaborator

OK, i found the issue and created a fix

@phampyk
Copy link
Author

phampyk commented Sep 25, 2024

OK, i found the issue and created a fix

Is there any hope to recover what I have, or should I delete all the tags and retag everything from 0?

@MohamedBassem
Copy link
Collaborator

@phampyk I think this only affected newly imported bookmarks. So we can help you craft a query to remove all those newly imported bookmarks. We can do it over discord

@kamtschatka
Copy link
Collaborator

there is no way to roll back unfortunately, but as @MohamedBassem said, it "only" affects newly imported bookmarks.

MohamedBassem added a commit that referenced this issue Sep 26, 2024
… tagName doesn't attach all tags to a bookmark #421 (#428)

* [Bug Report] Importing bookmarks adds all tags to all bookmarks #421
fixed an issue that caused all existing tags to be assigned to a new bookmark

* Add validation on the input of update tags to ensure that its not empty

---------

Co-authored-by: MohamedBassem <me@mbassem.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants