Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable issue_comment and check_run #366

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

teodorus-nathaniel
Copy link
Contributor

@teodorus-nathaniel teodorus-nathaniel commented Jan 21, 2025

resolves https://github.com/holdex/pr-time-tracker-webhooks/issues/448

I don't disable the custom-event yet, because its still used in the pull_requests events
once its merged, Ill check that the submission warning is not showing, and the reinsert warning doesn't work, and Ill enable the github app events for check_run and issue_comment

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
autoinvoice ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 8:16am

@teodorus-nathaniel teodorus-nathaniel self-assigned this Jan 21, 2025
Copy link

coderabbitai bot commented Jan 21, 2025

Walkthrough

The pull request modifies the src/lib/server/trigger-dev/jobs/index.ts file by introducing two new job definitions for GitHub events: issue-comment-streaming and check_run_streaming. These jobs are explicitly set with enabled: false, indicating that they are defined but currently inactive. The changes align with the job definition structure, maintaining consistency in how jobs are configured within the system.

Changes

File Change Summary
src/lib/server/trigger-dev/jobs/index.ts Added two new job definitions:
- issue-comment-streaming_${org.id}${isDev ? '_dev' : ''} with enabled: false
- check_run_streaming_${org.id}${isDev ? '_dev' : ''} with enabled: false

Assessment against linked issues

Objective Addressed Explanation
Disable check_run and issue_comment events [#448]

Possibly related PRs

Suggested reviewers

  • georgeciubotaru

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab5bbb7 and 78290da.

📒 Files selected for processing (1)
  • src/lib/server/trigger-dev/jobs/index.ts (2 hunks)
🔇 Additional comments (2)
src/lib/server/trigger-dev/jobs/index.ts (2)

42-42: LGTM! Successfully disabled issue comment streaming.

The change correctly disables the issue comment streaming job while maintaining the job definition structure.


122-122: LGTM! Successfully disabled check run streaming.

The change correctly disables the check run streaming job while maintaining the job definition structure and concurrency settings.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@teodorus-nathaniel teodorus-nathaniel marked this pull request as ready for review January 21, 2025 08:16
@georgeciubotaru georgeciubotaru merged commit 2a458c9 into main Jan 21, 2025
5 checks passed
@georgeciubotaru georgeciubotaru deleted the chore/disable-all-jobs branch January 21, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants