-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: disable pull_requests and pull_request_review event #367
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request modifies the job configurations in the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
… chore/disable-all-jobs
@georgeciubotaru before you merge, please go here https://github.com/organizations/holdex/settings/apps/pr-time-tracker/permissions so no events will be lost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
src/lib/server/trigger-dev/jobs/index.ts (3)
110-110
: Reassess the concurrency limit usage.With
enabled: false
, the concurrency limit for this custom event streaming job is effectively moot. Consider removing or commenting it out until the job is enabled to avoid confusion.
144-144
: Document reasons for disabling the Discord message job.By disabling this “Send Discord message” job, messages will not be sent. Confirm this is the desired behavior or track any plan to re-enable later.
159-159
: Ensure “Create Github bug report issue” job is not needed.Any bug-reporting workflow relying on this job will be interrupted. Confirm your team’s acceptance of this change.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/lib/server/trigger-dev/jobs/index.ts
(5 hunks)
🔇 Additional comments (2)
src/lib/server/trigger-dev/jobs/index.ts (2)
72-72
: Confirm that this job remains intentionally disabled.You've successfully disabled the “Streaming pull requests for Github” job by adding
enabled: false
. Verify that the project doesn't rely on this job being active, and consider documenting or tracking the requirement if you plan to enable it later.
87-87
: Confirm that this job remains intentionally disabled.You've disabled the “Streaming pull requests review for Github” job. Ensure there's no upstream or downstream dependency that expects it to be running.
@teodorus-nathaniel Did we resolve the custom event? As I can see we are disabling it |
@teodorus-nathaniel feel free to enable the events in the Github App and merge this PR |
@georgeciubotaru lets do the custom event in the next pr, which will be the last |
resolves https://github.com/holdex/pr-time-tracker-webhooks/issues/449
Summary by CodeRabbit