Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable pull_requests and pull_request_review event #367

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

teodorus-nathaniel
Copy link
Contributor

@teodorus-nathaniel teodorus-nathaniel commented Jan 24, 2025

resolves https://github.com/holdex/pr-time-tracker-webhooks/issues/449

Summary by CodeRabbit

  • Configuration Update
    • Disabled additional background jobs by default, including pull request streaming and review streaming.
    • Jobs remain configured but will not automatically run until explicitly enabled.

Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
autoinvoice ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 9:17am

Copy link

coderabbitai bot commented Jan 24, 2025

Walkthrough

The pull request modifies the job configurations in the src/lib/server/trigger-dev/jobs/index.ts file by adding the enabled: false property to two additional job definitions for the pull-requests-streaming and pull-requests-review-streaming jobs. This change standardizes the initial state of these jobs to be disabled by default, aligning them with other job definitions that already include the enabled: false property, while maintaining their existing logic and structure.

Changes

File Change Summary
src/lib/server/trigger-dev/jobs/index.ts Added enabled: false to the following job definitions:
- pull-requests-streaming_${org.id}${isDev ? '_dev' : ''}
- pull-requests-review-streaming_${org.id}${isDev ? '_dev' : ''}

Possibly related PRs

  • chore: disable issues job #364: This PR adds the enabled: false property to job definitions in the same file (src/lib/server/trigger-dev/jobs/index.ts), aligning with the changes made in the main PR to standardize job states.
  • chore: disable issue_comment and check_run #366: Similar to the main PR, this PR also introduces the enabled: false property to job definitions in the same file, indicating a direct connection in the context of job management.

Suggested reviewers

  • georgeciubotaru

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 515089c and 7a23e3e.

📒 Files selected for processing (1)
  • src/lib/server/trigger-dev/jobs/index.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/lib/server/trigger-dev/jobs/index.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@teodorus-nathaniel
Copy link
Contributor Author

teodorus-nathaniel commented Jan 24, 2025

@georgeciubotaru before you merge, please go here https://github.com/organizations/holdex/settings/apps/pr-time-tracker/permissions
and turn on the pull_request and pull_request_review events

so no events will be lost

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
src/lib/server/trigger-dev/jobs/index.ts (3)

110-110: Reassess the concurrency limit usage.

With enabled: false, the concurrency limit for this custom event streaming job is effectively moot. Consider removing or commenting it out until the job is enabled to avoid confusion.


144-144: Document reasons for disabling the Discord message job.

By disabling this “Send Discord message” job, messages will not be sent. Confirm this is the desired behavior or track any plan to re-enable later.


159-159: Ensure “Create Github bug report issue” job is not needed.

Any bug-reporting workflow relying on this job will be interrupted. Confirm your team’s acceptance of this change.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a458c9 and 515089c.

📒 Files selected for processing (1)
  • src/lib/server/trigger-dev/jobs/index.ts (5 hunks)
🔇 Additional comments (2)
src/lib/server/trigger-dev/jobs/index.ts (2)

72-72: Confirm that this job remains intentionally disabled.

You've successfully disabled the “Streaming pull requests for Github” job by adding enabled: false. Verify that the project doesn't rely on this job being active, and consider documenting or tracking the requirement if you plan to enable it later.


87-87: Confirm that this job remains intentionally disabled.

You've disabled the “Streaming pull requests review for Github” job. Ensure there's no upstream or downstream dependency that expects it to be running.

@georgeciubotaru
Copy link
Contributor

@teodorus-nathaniel Did we resolve the custom event? As I can see we are disabling it

@teodorus-nathaniel teodorus-nathaniel changed the title chore: disable remaining jobs chore: disable pull_requests and pull Jan 24, 2025
@teodorus-nathaniel teodorus-nathaniel changed the title chore: disable pull_requests and pull chore: disable pull_requests and pull_request_review event Jan 24, 2025
@georgeciubotaru
Copy link
Contributor

@teodorus-nathaniel feel free to enable the events in the Github App and merge this PR

@teodorus-nathaniel
Copy link
Contributor Author

@georgeciubotaru lets do the custom event in the next pr, which will be the last

@teodorus-nathaniel teodorus-nathaniel merged commit 8a70c7a into main Jan 24, 2025
5 checks passed
@teodorus-nathaniel teodorus-nathaniel deleted the chore/disable-all-jobs branch January 24, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants