Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests for polars.plot #1403

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Remove tests for polars.plot #1403

merged 3 commits into from
Aug 29, 2024

Conversation

ahuang11
Copy link
Collaborator

Polars replaced hvplot with altair in pola-rs/polars#17995

FAILED hvplot/tests/plotting/testcore.py::test_series_polars_downstream[violin] - polars.exceptions.ModuleUpgradeRequiredError: altair>=5.4.0 is required for .plot

@ahuang11 ahuang11 requested a review from hoxbro August 28, 2024 22:51
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (6c96c7e) to head (1424f78).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
+ Coverage   87.39%   88.80%   +1.40%     
==========================================
  Files          50       51       +1     
  Lines        7490     7494       +4     
==========================================
+ Hits         6546     6655     +109     
+ Misses        944      839     -105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro changed the title Pin upper polars version Remove test for polars.test Aug 29, 2024
@hoxbro hoxbro changed the title Remove test for polars.test Remove tests for polars.plot Aug 29, 2024
@hoxbro hoxbro merged commit fe81978 into main Aug 29, 2024
9 checks passed
@hoxbro hoxbro deleted the pin_polars branch August 29, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants