Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests for polars.plot #1403

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Remove tests for polars.plot #1403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
308ed30
pin polars version
ahuang11 Aug 28, 2024
8c9c60c
Unpin polars
hoxbro Aug 29, 2024
1424f78
Remove polars.plot tests
hoxbro Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions hvplot/tests/plotting/testcore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
from packaging.version import Version
from unittest import SkipTest

import numpy as np
import pandas as pd
import hvplot.pandas # noqa
Expand Down Expand Up @@ -96,13 +93,3 @@ def test_series_polars(kind):
ser = pl.Series(values=np.random.rand(10), name='A')
assert isinstance(ser, pl.Series)
ser.hvplot(kind=kind)


@pytest.mark.skipif(skip_polar, reason='polars not installed')
@series_kinds
def test_series_polars_downstream(kind):
if Version(pl.__version__) < Version('0.20.3'):
raise SkipTest('plot namespace in Polars introduced in 0.20.3')
ser = pl.Series(values=np.random.rand(10), name='A')
assert isinstance(ser, pl.Series)
ser.plot(kind=kind)
12 changes: 0 additions & 12 deletions hvplot/tests/testplotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,11 @@

from unittest import TestCase

import holoviews as hv
import pandas as pd
import pytest

from parameterized import parameterized

from hvplot.converter import HoloViewsConverter
from hvplot.plotting import plot
from hvplot.tests.util import makeDataFrame

no_args = ['line', 'area', 'hist', 'box', 'kde', 'density', 'bar', 'barh']
x_y = ['scatter', 'hexbin']
Expand Down Expand Up @@ -54,11 +50,3 @@ def test_pandas_dataframe_plot_does_not_implement_pie(self):
class TestPandasHvplotPlotting(TestPandasHoloviewsPlotting):
def setUp(self):
pd.options.plotting.backend = 'hvplot'


def test_plot_supports_polars():
pl = pytest.importorskip('polars')
dfp = pl.DataFrame(makeDataFrame())
out = plot(dfp, 'line')
assert isinstance(out, hv.NdOverlay)
assert out.keys() == dfp.columns
Loading