Load loading indicator from file instead of inlining #6112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
loading
indicators displayed on top of components were thus far always inlined as a stylesheet on each component. This is tremendously inefficient and also unnecessary to a certain extent. This change will load the SVG files either from CDN or from the local/static
endpoint like all other other CSS assets. The trick we are using here is to use a CSS-image-mask
and then set thebackground-color
using an inlined stylesheet. This does mean we can no longer set a separate low opacity gray background to indicate that the component is temporarily disabled or unresponsive.I'm still playing with alternative approaches but my basic idea is to use a CSS filter, starting with a
blur
filter.