Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading indicator background size #6207

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Fix loading indicator background size #6207

merged 1 commit into from
Jan 15, 2024

Conversation

philippjfr
Copy link
Member

Follow up fix for #6112 which incorrectly used background-size instead of mask-size to control the loading indicator size.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a203c63) 84.16% compared to head (1581672) 22.30%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6207       +/-   ##
===========================================
- Coverage   84.16%   22.30%   -61.87%     
===========================================
  Files         301      301               
  Lines       45099    45099               
===========================================
- Hits        37959    10058    -27901     
- Misses       7140    35041    +27901     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 22.30% <ø> (-49.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 7968858 into main Jan 15, 2024
12 of 15 checks passed
@philippjfr philippjfr deleted the loading_size_fix branch January 15, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant