Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon name #6411

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Add icon name #6411

merged 4 commits into from
Mar 4, 2024

Conversation

ahuang11
Copy link
Contributor

Closes #6401

image

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 71.57%. Comparing base (93b8d95) to head (47de775).

Files Patch % Lines
panel/tests/ui/widgets/test_icon.py 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6411      +/-   ##
==========================================
- Coverage   71.61%   71.57%   -0.05%     
==========================================
  Files         310      310              
  Lines       45841    45858      +17     
==========================================
- Hits        32831    32822       -9     
- Misses      13010    13036      +26     
Flag Coverage Δ
unitexamples-tests 71.57% <5.88%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 579d2e4 into main Mar 4, 2024
11 of 15 checks passed
@philippjfr philippjfr deleted the add_icon_name branch March 4, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If name is provided, should put text next to ButtonIcon
2 participants