Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide icon names in ChatReactionIcons #6433

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Hide icon names in ChatReactionIcons #6433

merged 2 commits into from
Mar 5, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Mar 4, 2024

With #6411, if a name is set, the icon will show a name on the side, and ChatReactionIcons uses that attribute to store its reactions initially.

This PR instead sets reaction on _reaction, but unsure if this is the best way to approach this.

Before:

image

After:

image

@ahuang11 ahuang11 requested a review from philippjfr March 4, 2024 19:08
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.62%. Comparing base (ecc2aab) to head (13a8076).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6433   +/-   ##
=======================================
  Coverage   71.62%   71.62%           
=======================================
  Files         310      310           
  Lines       45912    45913    +1     
=======================================
+ Hits        32884    32885    +1     
  Misses      13028    13028           
Flag Coverage Δ
unitexamples-tests 71.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 6608244 into main Mar 5, 2024
11 of 15 checks passed
@philippjfr philippjfr deleted the hide_icon_names branch March 5, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants