Fix state name for binary_sensor Power from clear/detected to on/off

[JoramQ]

Proposed change

A binary sensor shown as "Power" was displayed as Clear/Detected

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hi @JoramQ

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[home-assistant]

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (binary_sensor) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of binary_sensor can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign binary_sensor Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[epenet]

It may have been on purpose, so I'm cc-ing @frenck / @joostlek as author/reviewer of original PR: #97084

[joostlek]

I think there's a difference between being powered on and detecting power, the documentation points that its the latter

[JoramQ]

I am using Power to idicate a computer was turned on, has electricity. Therefore clear/detected sounds a bit strange to me. Its powered on/off. But i don't know other usecases of this Power so you might be right.

[TiHiNi]

Since this is a sensor, which job is to detect something, I think the existing description for on is correct and it should not be changed.

I don’t know if Clear in English is a good word for off. In German it is translated to normal, what assumed that it is not normal if power or gas is on. But that depends on the use case. In my opinion a sensor should not decide if the state is good or bad.

So, I would suggest something like undected or simple none.

@frenck : You made the old text, what do you think?

[TiHiNi]

I am using Power to idicate a computer was turned on, has electricity. Therefore clear/detected sounds a bit strange to me. Its powered on/off. But i don't know other usecases of this Power so you might be right.

Would not be running a better type for you?

[JoramQ]

i initially thought this needed to be fixed because the documentation is showing power (on/off)
https://www.home-assistant.io/integrations/binary_sensor/

I now do believe that a this sensor is for detecting if electricity is present, except power is watt so the name does not look perfect for me. But that might not be my problem. So for me this can stay as it is and we just need to update the documentation.

The main 'problem' that i now have that i want to show something as on/off(for whatever reason) but there is no possibility to do so if there is already a type defined. If there is already a type you can empty the selectbox but it goes back to default when you save. And the option "None" as in the documentation is not an option to choose. But this might be a new issue.

Stale

[emontnemery]

I agree clear / detected is a bit strange for a sensor wher "On means power detected, Off means no power.", but On / Off also doesn't seem great.
Maybe "Powered" / "Not powered"?

[frenck]

Checked history, I made this mess. Sorry 🙏

It originally was On / Off; during moving translations from the frontend to the backend, I've messed up.

[emontnemery]

Thanks, @JoramQ 👍

Stale