Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change POWER_VOLT_AMPERE_REACTIVE to UnitOfReactivePower #117153

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Change POWER_VOLT_AMPERE_REACTIVE to UnitOfReactivePower #117153

merged 5 commits into from
Aug 21, 2024

Conversation

NECH2004
Copy link
Contributor

@NECH2004 NECH2004 commented May 9, 2024 •
edited by MartinHjelmare
Loading

Breaking change

Proposed change

The constant 'POWER_VOLT_AMPERE_REACTIVE' was exchanged with the enumeration 'UnitOfReactivePower.VOLT_AMPERE_REACTIVE' as it was done for many constants (e.g. UnitOfPower.KILO_WATT) to ge a more consistant definition of power constants.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-needed core deprecation Indicates a breaking change to happen in the future has-tests labels May 9, 2024
home-assistant[bot]
home-assistant bot previously requested changes May 9, 2024
View reviewed changes
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NECH2004

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft May 9, 2024 18:40
@home-assistant
Copy link

home-assistant bot commented May 9, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@NECH2004 NECH2004 marked this pull request as ready for review May 9, 2024 18:44
@MartinHjelmare MartinHjelmare changed the title Refactoring: exchange POWER_VOLT_AMPERE_REACTIVE with UnitOfReactiveP… Change POWER_VOLT_AMPERE_REACTIVE to UnitOfReactivePower May 15, 2024
@farmio
Copy link
Contributor

farmio commented May 23, 2024

Here are two more occurrences of "var":

PS: there is no need to keep merging dev unless there are merge conflicts. Since you are a first time contributor, every time you do that someone has to manually approve a CI run.

@NECH2004
Copy link
Contributor Author

I have also changed the last two remaining code positions.

@frenck frenck self-assigned this Jul 6, 2024
@frenck frenck self-requested a review July 6, 2024 11:08
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 6, 2024
edenhaus
edenhaus previously requested changes Jul 11, 2024
View reviewed changes
homeassistant/const.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft July 11, 2024 15:11
@NECH2004 NECH2004 marked this pull request as ready for review July 12, 2024 10:54
@home-assistant home-assistant bot requested a review from edenhaus July 12, 2024 10:54
emontnemery
emontnemery reviewed Aug 21, 2024
View reviewed changes
homeassistant/const.py Outdated Show resolved Hide resolved
emontnemery
emontnemery approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @NECH2004 👍

@emontnemery emontnemery merged commit 3e53cc1 into home-assistant:dev Aug 21, 2024
36 checks passed
@NECH2004 NECH2004 deleted the refactor_va branch August 21, 2024 17:56
raman325 added a commit to raman325/home-assistant that referenced this pull request Aug 22, 2024
@raman325
Merge branch 'dev' into label
5797c23 
* dev: (642 commits)
  Improve config flow type hints (part 4) (home-assistant#124348)
  Improve config flow type hints (part 1) (home-assistant#124343)
  Add tests for Bring integration (home-assistant#123087)
  Add DROP Alert product support (home-assistant#117867)
  update ttn_client - fix crash with SenseCAP devices (home-assistant#124370)
  Add Aranet Radon Plus support (home-assistant#124197)
  Fix Spotify Media Browsing fails for new config entries (home-assistant#124368)
  Convert Bang & Olufsen testing logging patches to caplog (home-assistant#124366)
  Remove unneeded check for Bang & Olufsen events and device update (home-assistant#124363)
  Bump async-interrupt to 1.2.0 (home-assistant#124360)
  Rename OpenThermGatewayDevice to OpenThermGatewayHub (home-assistant#124361)
  Fix Weatherflow Cloud lightning (home-assistant#124082)
  Change POWER_VOLT_AMPERE_REACTIVE to UnitOfReactivePower (home-assistant#117153)
  Disable Habitica deprecated entities by default (home-assistant#123522)
  Add test cases for ViCare entities (home-assistant#122983)
  Add tests for IronOS integration (home-assistant#123078)
  Fix state name for binary_sensor Power from clear/detected to on/off (home-assistant#116994)
  Extend blebox shutterbox tilt support (home-assistant#110547)
  blebox: use blebox_uniapi.cover.BleboxCoverState enum members instead of plain integers (home-assistant#124302)
  Add custom panel for LCN configuration (home-assistant#108664)
  ...
epenet added a commit to epenet/home-assistant-core that referenced this pull request Aug 22, 2024
@epenet
Revert "Change POWER_VOLT_AMPERE_REACTIVE to UnitOfReactivePower (hom…
16edbcd 
…e-assistant#117153)"

This reverts commit 3e53cc1.
@epenet epenet mentioned this pull request Aug 22, 2024
Merged
19 tasks
epenet added a commit that referenced this pull request Aug 22, 2024
@epenet
Revert UnitOfReactivePower change from iotawatt (#124393)
4e3bd55 
Revert "Change POWER_VOLT_AMPERE_REACTIVE to UnitOfReactivePower (#117153)"

This reverts commit 3e53cc1.
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@epenet epenet epenet left review comments

@emontnemery emontnemery emontnemery approved these changes

@home-assistant home-assistant home-assistant left review comments

@kellerza kellerza Awaiting requested review from kellerza kellerza is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

@starkillerOG starkillerOG Awaiting requested review from starkillerOG starkillerOG is a code owner

@farmio farmio Awaiting requested review from farmio farmio is a code owner

@MartinHjelmare MartinHjelmare Awaiting requested review from MartinHjelmare MartinHjelmare is a code owner

@frenck frenck Awaiting requested review from frenck

@edenhaus edenhaus Awaiting requested review from edenhaus

Assignees

@frenck frenck

Labels
cla-signed core deprecation Indicates a breaking change to happen in the future has-tests smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@NECH2004 @farmio @MartinHjelmare @epenet @emontnemery @edenhaus @frenck