-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic ZHA Zeroconf discovery #126294
Generic ZHA Zeroconf discovery #126294
Conversation
Hey there @dmulcahey, @Adminiuga, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
CC @tube0013 |
@Hedda In the future, please do not ask other projects to implement draft PRs. This code isn't done or in a final form and now I have to communicate with other developers to change the schema. |
d80edde
to
32bdbcc
Compare
Thanks for the review! I've addressed both comments and reworked unit tests to properly increase coverage. |
Maybe register it here as well https://www.iana.org/form/ports-services |
@bdraco ah, good point. It's already registered but there's no info about what keys are allowed, nor any public references to devices actually using it 😅. I'll see what I can dig up. |
Marking as draft until I hear back from a few people. If there's an existing and active registration we'll have to rename this. If not, we'll continue with this name. |
|
Looks like CI is having some issues right now. Thanks for the review, @abmantis. I think I've addressed your review comments. |
Proposed change
I'm introducing a new service type:
_zigbee-coordinator._tcp.local.
. This will allow all future TCP coordinators to be supported without an explicit PR to ZHA. The only expected properties areradio_type
(one ofezsp
,znp
, etc.) andserial_number
(must be unique per device and not derived from any Zigbee information, like the Ethernet MAC address). The service name will be shown as-is.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: