-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove universal XZG Firmware under recommended adapters #35118
Conversation
Remove universal XZG Firmware since it itself is an Zigbee Coordinator adapter - [XZG - Universal Firmware for Zigbee Gateway](https://xzg.xyzroe.cc/)
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
📝 WalkthroughWalkthroughThe changes in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ZHA
participant ZigbeeDevice
User->>ZHA: Configure Zigbee integration
ZHA->>User: Provide configuration options
User->>ZHA: Select device and set parameters
ZHA->>ZigbeeDevice: Permit new device
ZigbeeDevice-->>ZHA: Device connected
ZHA->>User: Device added successfully
User->>ZHA: Troubleshoot connection issues
ZHA->>User: Provide troubleshooting steps
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@Hedda This statement is not true, because XZG only supports TI 2652*. Support for other families is not implemented. |
@xyzroe XZG firmware is open-source so what is stopping anyone from using it on for example anDIY or Smlight’s EFR32MG21 and/or EFR32MG24 based adapters? They might not be able to use all the extra features out of the box but can still use the serial to iP server which is the only feature that is direct relevant to the ZHA integration. |
xyzroe/XZG#66 |
I don't think a generic serial-to-TCP firmware itself is useful to note in ZHA documentation, as issues with specific adapters won't reflect in the firmware. Once home-assistant/core#126294 is finished the specific TCP-enabling firmware will be irrelevant, since they all will be supported identically. |
Proposed change
Remove listing of universal XZG Firmware under the list of recommended radio adapters since the XZG Firmware linked is not actually a Zigbee Coordinator adapter pruduct itself but instead a open-source firmware SDK for ESP32 that allows anyone to create a network-attached Zigbee Coordinator as a Serial over IP proxy, and because it is not a specific product it would not be a good idea to add it to the list there as blanket recommendation for any adapter that is built using XZG Firmware, and there is today in fact multiple companies and people making XZG Firmware based adapters that use different Zigbee Coordinator chips (including both various Texas Instruments and Silicon Labs radio MCUs as well as others).
https://github.com/xyzroe/XZG
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
This will partially revert #33161 but not the important part about auto discovery.
Please do not get me wrong, @xyzroe is doing a great job, but the "XZG Firmware" itself does not belong under the list of recommend radio adapters for ZHA as it is not a specific adapter so it can not be generalized as a catch-all for all possible adapters based on it today and in the future.
Checklist
current
branch.Summary by CodeRabbit