Bump async-upnp-client to 0.15.0

[B5r1oJ0A9G]

Breaking change

Proposed change

Update required version to current version of async-upnp-client.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes the dependency issue of the Teufel Raumfeld integration: Release 0.1.2-alpha dependency to async-upnp-client breaks integration B5r1oJ0A9G/teufel_raumfeld#7. Teufel Raumfeld depends on HTTP header support and retention of XML values implemented with release 0.15.0 of async-upnp-client.
• Changelog release 0.15.0 of async-upnp-client: https://github.com/StevenLooman/async_upnp_client/blob/development/CHANGES.rst
• Comparing changes release 0.15.0 to 0.14.13: StevenLooman/async_upnp_client@0.14.13...0.15.0

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[MartinHjelmare]

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

[B5r1oJ0A9G]

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

Requested information added to section "Additional information".

[B5r1oJ0A9G]

While this requested change was sufficient in my dev environment, it appears to require some more changes, at least with Docker:

bash-5.0# grep -r "async-upnp-client==0.15.0" /usr/src/homeassistant/
/usr/src/homeassistant/homeassistant/package_constraints.txt:async-upnp-client==0.15.0
/usr/src/homeassistant/homeassistant/components/ssdp/manifest.json:  "requirements": ["defusedxml==0.6.0", "netdisco==2.8.2", "async-upnp-client==0.15.0"],
/usr/src/homeassistant/homeassistant/components/upnp/manifest.json:  "requirements": ["async-upnp-client==0.15.0"],

As the version is also pinned in other contexts, it seems to be a more comprehensive effort to coordinate:

/usr/src/homeassistant/homeassistant/components/dlna_dmr/manifest.json:  "requirements": ["async-upnp-client==0.14.13"],
/usr/src/homeassistant/requirements_all.txt:async-upnp-client==0.14.13
/usr/src/homeassistant/requirements_test_all.txt:async-upnp-client==0.14.13

[MartinHjelmare]

Yes, update the upnp manifest and then run the requirements script per the bullet in the PR description.

[homeassistant]

Hi @drprofesq,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[B5r1oJ0A9G]

In efdd99f the version is pinned accordingly for the componnents ssdp, dlna_dmr and upnp. In the end only the update concerning ssdp lead to the necessary update of package_constraints.txt.

As for dlna_dmr and upnp, @StevenLooman agrees with the increase of the required version for async-upn-clientto 0.15.0: StevenLooman/async_upnp_client#50 (comment).

[StevenLooman]

Agreed. 0.15.0 introduces some additions not particularly relevant to upnp. dlna_dmr might have some impact due to relaxed didl lite parsing, but I doubt problems will arise from this as the changes are minor. Another change to 0.15.0 is that it supports ssdp over IPv6. Testing this properly is important! If any changes/fixes need to be applied to async_upnp_client I am able to merge quickly and release a new version. I didn't know the ssdp component uses async_upnp_client, but great to hear. This does, however, 'bind' four components to a specific version of async_upnp_client. Can this pose a problem, now or in the future?

[StevenLooman]

I have created #48521 to bump async_upnp_client to 0.16.0. This PR can be closed. Don't want to steal your thunder @B5r1oJ0A9G, but the last release of async_upnp_client did not include everything I needed for #46822.