Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump async_upnp_client to 0.16.0 #48521

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

StevenLooman
Copy link
Contributor

Proposed change

Bump async_upnp_client to 0.16.0 from 0.14.3, containing some fixes.

Note that this PR invalidates PR #47885.

Also note that this change to async_upnp_client providers IPv6 support which impacts SSDP-advertisement behavior. Testing this (by others, not being me) should be done.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Mar 31, 2021

SSDP discovery still working 👍

  • H network container
  • M network container
  • M network os
  • Run profile - no increase - looks good. might be able to optimize it a bit:

Screen Shot 2021-03-30 at 3 37 35 PM

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test pass. Thanks!

@bdraco bdraco merged commit 7a6c88f into home-assistant:dev Mar 31, 2021
@StevenLooman
Copy link
Contributor Author

Wow that was really quick, thanks @bdraco.

Wondering though, is this a profiler graph and how did you generate it?

@bdraco
Copy link
Member

bdraco commented Mar 31, 2021

Wow that was really quick, thanks @bdraco.

Wondering though, is this a profiler graph and how did you generate it?

I'm using the profiler integration with qcachegrind

https://www.home-assistant.io/integrations/profiler/

@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2021
@StevenLooman StevenLooman deleted the async_upnp_client__0_16_0 branch May 9, 2021 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants