-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homebridge UI plugin menu items for some plugins missing #2070
Comments
Same for me, I think it is related to #2069 |
Additionally: newer published versions are now shown as being available, the user has no visibility of any updates. |
Indeed, I observe the following for my affected plugin in my dev environment: |
@jsiegenthaler @grzegorz914 you need to add manualy in plugin package.json |
That NPM has stopped adding maintainers field feels like a bug in NPM and should be fixed there. The NPM Documentation does not document a "maintainers" field but explicitly states... "npm also sets a top-level "maintainers" field with your npm user info." In addition, the npmjs.com package settings page lists maintainers and allows you to invite another person to be added as a maintainer... all done outside of the package.json source file. If this is the documented behavior, then it's a bug in NPM that it has stopped adding this field. |
And over here npm states themselves... "The "maintainers" field in the top-level of the registry metadata (ie, not versioned) is the npm-controlled list of the npm usernames of the people with permission to write to that package. This can be modified via the npm owners command." (emphasis mine). So I believe that it is not correct to recommend adding maintainers field to each package.json file. |
To summarize:
So adding maintainers to package.json is only workaround until Homebridge UI and NPM fix errors. |
@mkz212 yes good summary... I was working on my plugin and noticed the problem, I tracked it down to checking the length statement then discovered that it had just been fixed, so all good from Homebridge side. I do think that NPM need to fix their bug. Is there a bug report open? |
I believe the issue I just experienced may be related to this. I set up the Homebridge Simplisafe3 by @nzapponi yesterday and tested arming and disarming my alarm through a HomeKit scene successfully. This morning I ran my scene that should have turned the alarm off, but found out it had not when the security company called because the alarm went off when it should have been turned off 4 hours ago by my HomeKit scene. Looking at the plugin log, all I see is this: [6/22/2024, 12:44:14 AM] [Alarm] Initializing homebridge-simplisafe3.SimpliSafe 3 platform... However, the Homebridge log shows the following occurring afterwards. [6/22/2024, 1:10:08 AM] [Homebridge UI] Running job to cleanup config.json backup files older than 60 days... I have now tested arming and disarming using my HomeKit scene and it appears to be working now. I cannot find an explanation as to why the Good Morning scene that turns the alarm off did not run 4 hours ago as it should have. I would appreciate any insight. |
I have the same problem, all day |
|
To fix error in plugin you need to add manualy in plugin package.json |
@solomonj1963 Everyone now have error |
|
@mkz212 Can you elaborate on this comment - We cannot update Homebridge UI. I just went and updated mine and had no issues. |
I have UI 4.56.2, so the last version before fix. It shows me error in logs: This is because latest release of Homebridge UI - 4.56.3 has no maintainers in package.json. So it doesn't show me update option. Version 4.56.2 check lenght of maintainers but not check first that maintainers exist. And in 4.56.3 maintainers not added to package.json so doesnt exist. |
if you have UI 4.56.2 then you are not on the latest. v4.56.3 has the fix for this, this is resolved. |
Yes. I know. But we cannot update to 4.56.3 because you release it with package.json without maintainers. So now every version before 4.56.3 check for the maintainers lenght from the latest release what produce error because there is NO maintainers in latest release! Why closind Issue when users report that still have errors? If before npm always automatically added maintainers to the package, and now it stopped and this causes a problem, why not just add maintainers yourself and publish? Is it a problem? |
@mkz212 I just went into the UI and selected 4.56.3 |
Oh, okay, I already know what it's about and why we don't understand each other. I mean that there is a error in the logs (and users dont know what is it) and that the update notification does not pop up. So users do not know there is fix. Not everyone knows that you have to click on the Homebridge UI text on the widget to open the version selection window - It's not so obvious, because most people are used to the notification shows up! |
That's right @mkz212. I'm a fairly experienced homebridge user I think, but I was surprised to see there was a later version under the install dialog, with 'Up to Date' as the status for Homebridge UI. |
That's what I mean! Everyone is so used to the fact that a notification about the update shows up that no one even knows that there is an option to install the selected version after you click on Homebridge UI text. BTW: such an option to instalk other version should also be in settings / UI settings. |
I'm sorry to be so dense but I cannot see any clickable Homebridge UI text. I have homebridge-config-ui-x v4.52.2 but neither the "Homebridge UI" text in the Plugins window nor the "homebridge-config-ui-x v4.52.2" text is clickable. And the only entry in Homebridge UI vertical ellipses menu is "API Documentation". How do I install homebridge-config-ui-x v4.52.3. |
In Status tab (there where you have widgets and qr code). |
@oogje Good Question. It's from the Status Page in a box that looks like this |
@oogje click reset layout (you already have this widget but i think it is cropped somehow) |
@mkz212 , I edited my last comment to show the reset layout. |
@oogje hmm... this is strange. It should be there. So this is a bug. You can also try run terminal (in Homebridge, not mac os terminal) and type: |
@mkz212 Will do. Thank you! |
@mkz212 - In regards to the "maintainers" field with package.json, as it is documented as being supplied by npm, and not a user supplied field, lets wait and see what happens on the npm side over the next few days. I expect that is an issue with a recent release on their side, and would expect it to be resolved by them within a few days. |
If you install homebridge as documented here, then npm is not available...
I do not know if it is safe to install npm as that looks to drag a whole nodejs environment, which may be different from that included with homebridge (it says 527 new packages will be installed !!!) Bottom line, we shouldn't require command line to update this plugin. |
I agree. |
I opened a support ticket with NPM on Thursday, along with this thread on GitHub Community (which is what they say to do when giving feedback, according to this). If anyone wants to chime in on that thread, or upvote it, or whatever, it might get them to investigate it sooner rather than later |
Upvoted |
I'm glad this is figured out and my instance is fixed now. However, I would like to point out that, due to the notification "bug", there are probably still thousands of installations out there where the person is not even aware of it. I was not aware of it until my alarm monitoring company called me for tripping my alarm when it should have been turned off via HomeKit but wasn't. I'd like to point out that sometimes the impact of a bug can be larger than the developers realize, and I'm concerned that there needs to be a method developed to make sure existing users do get notified and apply the update. I don't believe saying this is completed is really true, as a manual fix has been identified and only known to people who find this discussion. With all due respect, I believe something creative should be implemented to assure every user is notified of the update that has been lurking in the shadows. I appreciate everything all you developers do for us, I truly do! But unless I'm missing something here, this missing notification remains a high impact bug and people are still not being notified. |
There is zero discussion on that thread... which is rather discouraging after 4 days for something that will impact 1000's of packages. |
@solomonj1963 this bug is only related to the Homebridge UI asynchronously checking for updates on existing packages, it wouldn't have any impact on the functionality of the plugins themselves |
If you have UI v.4.56.2 or below, for every plugin that doesn't have maintainers in package.json in latest release, you cannot update plugin and cannot access 'Instal other version' in plugin menu. So some impact is... |
That is true! I just wanted to clarify because I don't think this bug had anything to do with what was being described in this comment |
Thank you for the response. I hope you are correct with that. In my case, all I can say is that I had a "Good Morning" scene which included setting my Simplisafe alarm system to off. The same scene triggers alot of other activity around my home that did occur. The only device used in that scene that is on my homebridge instance is the Simplisafe system. I had nothing showing in any of my logs that homebridge or my plugins saw that I had activated that scene. Other devices on my home-assistant platform did see it and acted as expected. So, I'm not complaining, but I feel like this was a big gap in my instance and it is within reason it could be for others. I'm only recommending a little more thought be invested on this potential impact. |
The problem is even worse, because the UI 4.56.2 and below are not detecting that there is a new UI release. To test, I just installed hombridge following instructions here. And it installed UI v4.56.2 and reports that it is up-to-date... So your average user has no idea that the Homebridge UI is out-of-date, AND will not get any prompting for ANY other plugin that has had an update published.... unless the plugin owner adds the maintainers list to their package.json. And... this UI needs to add it to its own package.json, which will hopefully then cause homebridge to highlight that a new UI is available. |
Opened #2076 as this one is closed. |
Describe The Bug
Some recently published plugins are missing the Manage Version and Report An Issue items in the plugin menu, and the author name is missing beside the @ symbol.
You can still click on the @ symbol to display the Donate to window, but the @ in front of the author name is missing.
Normal display of menu items and author name:
Plugin missing the menu items and author name:
This is particularly problematic as the user cannot change to another plugin version due to the missing Manage Version item
Normal display of Donate to:
Display of Donate to for a plugin where the author name is missing:
You can still click on the single @ character to open the Donate to window
Logs
No response
Config
No response
Homebridge UI Version
4.56.2
Homebridge Version
1.8.3
Node.js Version
20.14.0
Operating System
Raspberry Pi OS / Raspbian
Environment Info
Using hb-service
Raspberry Pi Model
Raspberry Pi 4 B
The text was updated successfully, but these errors were encountered: