-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that pkg.maintainers
is defined before checking it's length
#2069
Check that pkg.maintainers
is defined before checking it's length
#2069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks!
Patched my environment with this fix. The source also seems to end up in Anyways, this PR solves the missing menu items, but doesn't solve the missing author. The author still seems to be in the response, under |
pkg.containers
is defined before checking it's lengthpkg.maintainers
is defined before checking it's length
|
If you want to fix errors in plugins (until this patch will be released) you need to:
I think that this patch should be released ASAP, cause every new public release without maintainers in package.json will generate errors. And maybe not only first maintainer? Maybe first 4 maintainers? |
@mkz212's workaround seems to work. Note that it's actually |
Sorry, yes, colon! |
Workaround for npm / Homebridge UI issue homebridge/homebridge-config-ui-x#2069.
## v4.56.3 (2024-06-22) ### Fixed - Check that pkg.maintainers is defined before checking it's length (#2069) (@PatrickStankard)
- Check that pkg.maintainers is defined before checking it's length (#2069) (@PatrickStankard)
4.56.3 should be released soon. |
Ran into a test coverage issue that needs to be resolved first |
- Check that pkg.maintainers is defined before checking it's length (#2069) (@PatrickStankard)
- Check that pkg.maintainers is defined before checking it's length (#2069) (@PatrickStankard)
- Check that pkg.maintainers is defined before checking it's length (#2069) (@PatrickStankard)
♻️ Current situation
For some reason, NPM doesn't seem to be setting the
maintainers
key on packages in the registry right now. I only noticed this because I was seeing this error in the Homebridge UI after publishing an update to a package:💡 Proposed solution
Check that
pkg.maintainers
is defined before checking it's length