add check if the app prefix exists #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Will push this out shortly. |
tredman
added a commit
that referenced
this pull request
Jan 23, 2020
#96 added a string content check to the trace field name, but there were previously no checks to ensure that this value is in fact a string. Any customer using the beeline that picks up that patch and is using unusual types here could crash, so I added some type checking before bumping the version on this release.
|
2.11.3 is now out |
This was referenced Jun 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reserving a trace_field from CTX the names all ready start with the prefix app. so we receive duplicate prefix app.app.
example:
AWS lambda x is using add_trace_field("id", "i-1") (in honeycomb we will see it as app.id as expected).
lambda x sending its CTX to lambda y, in honeycomb we will see app.app.id and not app.id as expected