Add type safety checking in add_trace_field, bump version #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#96 added a string content check to the trace field name, but there were previously no checks to ensure that this value is in fact a string. Any customer using the beeline that picks up that patch and is using unusual types here could crash, so I added some type checking before bumping the version on this release.
paulosman
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#96 added a string content check to the trace field name, but there were previously no checks to ensure that this value is in fact a string. Any customer using the beeline that picks up that patch and is using unusual types here could crash, so I added some type checking before bumping the version on this release.