Add metrics from samplers #704
Labels
type: enhancement
New feature or request
Milestone
Comments
kentquirk
added a commit
that referenced
this issue
Jun 12, 2023
## Which problem is this PR solving? - Adds sampler-specific metrics now that dynsampler-go supports them. ## Short description of the changes - Add getMetricType function to get the type from a metric by its name. This is required because Metrics can only increment counters, not set them to a value, so we need to treat metrics ending in _count specially by keeping track of their previous value so we can get a delta. - Register all metrics provided by the sampler - Record them on every call to GetSampleRate - Add metrics to DeterministicSampler following the same pattern - Update rules to do the same (and add support for new downstream sampler types) Closes #704. Closes #554.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Supporting samplers is hard because they have no metrics and no visibility into their internal state. We'd like to be able to see some things like the size of the keyspace in the samplers.
Describe the solution you'd like
Samplers have metrics and Refinery reports those metrics
Additional context
This PR adds metrics support to dynsampler-go. Once that merges, Refinery could use it.
The text was updated successfully, but these errors were encountered: