Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to turn off config polling #726

Closed
TylerHelmuth opened this issue Jun 21, 2023 · 0 comments · Fixed by #730
Closed

Add ability to turn off config polling #726

TylerHelmuth opened this issue Jun 21, 2023 · 0 comments · Fixed by #730
Assignees
@TylerHelmuth
Labels
type: enhancement New feature or request
Milestone
v2.0

Comments

@TylerHelmuth
Copy link
Contributor

Is your feature request related to a problem? Please describe.
At the moment Refinery has the ability to configure how often the config file is polled for changes, but it does not let you turn off this feature.

Describe the solution you'd like
Add the ability to turn off config polling by passing in a value of 0 in the configuration section.
@TylerHelmuth TylerHelmuth added the type: enhancement New feature or request label Jun 21, 2023
@TylerHelmuth TylerHelmuth added this to the v2.0 milestone Jun 21, 2023
@TylerHelmuth TylerHelmuth self-assigned this Jun 21, 2023
@TylerHelmuth TylerHelmuth mentioned this issue Jun 21, 2023
Merged
kentquirk pushed a commit that referenced this issue Jun 21, 2023
@TylerHelmuth
feat: Allow disabling reload monitoring (#730)
5ec18a4 
## Which problem is this PR solving?

- Closes #726

## Short description of the changes

- Adds the ability to disable config polling by setting
`ConfigReloadInterval` to `0s`.
- Adds new test that confirms the feature is disabled.
- Generates new configs with updated description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TylerHelmuth TylerHelmuth

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

feat: Allow disabling reload monitoring honeycombio/refinery
1 participant
@TylerHelmuth