Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow disabling reload monitoring #730

Merged
merged 2 commits into from
Jun 21, 2023
Merged

feat: Allow disabling reload monitoring #730

merged 2 commits into from
Jun 21, 2023

Conversation

TylerHelmuth
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Adds the ability to disable config polling by setting ConfigReloadInterval to 0s.
  • Adds new test that confirms the feature is disabled.
  • Generates new configs with updated description

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner June 21, 2023 17:35
@TylerHelmuth TylerHelmuth requested a review from kentquirk June 21, 2023 17:52
kentquirk
kentquirk approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good test, too.

@kentquirk kentquirk merged commit 5ec18a4 into main Jun 21, 2023
@kentquirk kentquirk deleted the tyler.turn-off-config-polling branch June 21, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to turn off config polling
2 participants
@TylerHelmuth @kentquirk