Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRPCServerParameters.Enabled is unused. #770

Closed
TylerHelmuth opened this issue Jul 7, 2023 · 0 comments · Fixed by #771
Closed

GRPCServerParameters.Enabled is unused. #770

TylerHelmuth opened this issue Jul 7, 2023 · 0 comments · Fixed by #771
Labels
type: bug Something isn't working
Milestone
v2.0.1

Comments

@TylerHelmuth
Copy link
Contributor

TylerHelmuth commented Jul 7, 2023 •
edited
Loading

Versions

  • Refinery: 2.0.0

Steps to reproduce

  1. Set GRPCServerParameters.Enabled=false and set GRPCServerParameters.ListenAddr to an address
  2. Observe that Refinery does start up a grpc endpoint.

Additional context

I appears that GRPCServerParameters.Enabled is not used anywhere. Setting GRPCServerParameters.ListenAddr is effectively enabling to feature.
@TylerHelmuth TylerHelmuth added the type: bug Something isn't working label Jul 7, 2023
@TylerHelmuth TylerHelmuth mentioned this issue Jul 7, 2023
Merged
@TylerHelmuth TylerHelmuth added this to the v2.0.1 milestone Jul 7, 2023
TylerHelmuth added a commit that referenced this issue Jul 10, 2023
@TylerHelmuth
fix: Update file_config to honor GRPCServerParameters.Enabled (#771)
83d1f6e 
## Which problem is this PR solving?

- Closes #770

## Short description of the changes

- Add a `GetGRPCEnabled` function to config interface.
- Update file_confg and mock to implement `GetGRPCEnabled`
- Update grpc server logic to check if enabled.
- Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging a pull request may close this issue.

fix: Update file_config to honor GRPCServerParameters.Enabled honeycombio/refinery
1 participant
@TylerHelmuth