fix: Update file_config to honor GRPCServerParameters.Enabled #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
added
the
version: bump patch
TylerHelmuth
force-pushed
the
tyler.fix-GRPCServerParameters.Enabled
branch
from
5d7ce36 to
9a04507
Compare
akvanhar
reviewed
Jul 7, 2023
kentquirk
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
This part looks good, but I think this also requires a change to configMeta.yaml and maybe the . Specifically, the Enabled flag needs:
valuetype: conditional
extra: "nonempty GRPCListenAddr"
and the "conditional" helper needs to get the "nonempty" case added.
It would be ok to do those as a separate PR, or as part of this one.
|
@kentquirk added the case and then tested with the 1.19.1 helm chart values. They were successfully converted when the grpc address was supplied. |
…arameters.Enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
GRPCServerParameters.Enabledis unused. #770Short description of the changes
GetGRPCEnabledfunction to config interface.GetGRPCEnabled