Add a TotalThroughputSampler. #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. Thank you for bringing it in! |
martin308
reviewed
Oct 22, 2020
There was a problem hiding this comment.
Looks good, thanks @magnusstahre, once we get #186 in then we can refactor this to use the new shared key generation, and once #188 is merged the build should pass!
|
@magnusstahre I'm also happy to make the above changes to your PR if you like? |
magnusstahre
force-pushed
the
totalthroughput
branch
from
5f52951 to
f53df60
Compare
magnusstahre
force-pushed
the
totalthroughput
branch
from
f53df60 to
1d2bd15
Compare
martin308
added a commit
that referenced
this pull request
Oct 23, 2020
These builds don't have the required ENV variables to run this step. This can be seen in #185
martin308
requested changes
Oct 23, 2020
Co-authored-by: Martin Holman <me@martinholman.co.nz>
martin308
approved these changes
Oct 28, 2020
|
@martin308 are you able to cut a release that has this change in it? thanks! |
|
Hey @magnusstahre - I've just published v0.13.0 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.