Handle all the datatypes in the EMA sampler #186
Conversation
Now that we suport msgpack the types that might be in the data hash are more varied than they used to be. Add ability to format any type as a string
|
It looks like the regular dynamic sampler is also going to be impacted by this, will update that as well |
| "app.team.id": float64(4), | ||
| "important_field": true, | ||
| "request.path": "/{slug}/fun", | ||
| "meta.key": "4•,200•,true•,/{slug}/fun•,", |
There was a problem hiding this comment.
while we're in here improving the test, would it be useful to ensure the "multiple instances of the same field get collapsed to their smallest set of unique values" behavior is working as well? This may be pushing the boundaries of this test and an explicit test of the buildKey function would fit better, but I don't have a strong opinion there.
(Since there are 5 spans in this trace, the "collapse similar values" portion of that is being tested by only having one 200 show up instead of 5, but if we had 3 200s and 2 429s it'd be nice to see 200•429 as the value in the key.)
There was a problem hiding this comment.
added some tests to cover this scenario!
Now that we support msgpack the types that might be in the data hash are more varied than they used to be.
Adds the ability to format any type as a string in order to handle this